Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest version 2 is deprecated #68

Closed
FahimFBA opened this issue May 25, 2022 · 6 comments
Closed

Manifest version 2 is deprecated #68

FahimFBA opened this issue May 25, 2022 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@FahimFBA
Copy link
Contributor

FahimFBA commented May 25, 2022

We are getting an error saying the manifest version 2 is deprecated. Check the picture below.


Screenshot 2022-05-26 002946

@TheCedarPrince
Copy link

Can confirm I am also getting this but it doesn't prevent the extensions from being used at the moment.

@Cveinnt
Copy link
Contributor

Cveinnt commented May 26, 2022

It looks like migrating to V3 manifest is a bit more complicated then I thought - the webpack-extension-reloader package used for this extension is no longer maintained and does not support V3 (more here) which means the service worker registration will fail for v3 manifests.

@ansh
Copy link
Owner

ansh commented May 29, 2022

@Cveinnt We were using v3 before but had to switch to v2 to support Firefox.

Do you have any suggestions on moving back to v3? @mehbubhussain

@ansh ansh added the help wanted Extra attention is needed label May 29, 2022
@asieduernest12
Copy link
Collaborator

chrome is the one complaining about version 3 and we can add an extra build step to process the manifest file to work correctly with v3
this also has to account for some of the api calls chrome.tabs.sendMessage and chrome.runtime

@neelkarma
Copy link

It looks like migrating to V3 manifest is a bit more complicated then I thought - the webpack-extension-reloader package used for this extension is no longer maintained and does not support V3 (more here) which means the service worker registration will fail for v3 manifests.

Looks like a company maintains a fork of it over at https://github.com/SimplifyJobs/webpack-ext-reloader/ and that there is an issue tracking MV3 support there over at SimplifyJobs/webpack-ext-reloader#28

@asieduernest12
Copy link
Collaborator

We can close this, since we are now using the plasmo framework and the chrome build has manifest v3.
i am still learning how to use it well but it looks ok for now. though not version 1 actually so potential issues could arrise.

Firefox build will still be on v2 till they switch the browser to demand v3 by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants