From 5f69b724ccd06741e6c2409f45d156b3d6b9bde3 Mon Sep 17 00:00:00 2001 From: mingjun-ansible Date: Wed, 12 Jul 2023 09:25:38 -0700 Subject: [PATCH] Address review comments --- .../network/sonic/config/radius_server/radius_server.py | 2 +- .../network/sonic/utils/formatted_diff_utils.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/module_utils/network/sonic/config/radius_server/radius_server.py b/plugins/module_utils/network/sonic/config/radius_server/radius_server.py index 24a3aff04..4dca5548c 100644 --- a/plugins/module_utils/network/sonic/config/radius_server/radius_server.py +++ b/plugins/module_utils/network/sonic/config/radius_server/radius_server.py @@ -105,7 +105,7 @@ def execute_module(self): result.pop('after', None) new_config = get_new_config(commands, existing_radius_server_facts, TEST_KEYS_formatted_diff) - result["after(generated)"] = new_config + result['after(generated)'] = new_config if self._module._diff: result['config_diff'] = get_formatted_config_diff(existing_radius_server_facts, diff --git a/plugins/module_utils/network/sonic/utils/formatted_diff_utils.py b/plugins/module_utils/network/sonic/utils/formatted_diff_utils.py index c4ff7b70e..457625e0d 100644 --- a/plugins/module_utils/network/sonic/utils/formatted_diff_utils.py +++ b/plugins/module_utils/network/sonic/utils/formatted_diff_utils.py @@ -412,9 +412,9 @@ def get_formatted_config_diff(exist_conf, new_conf): bfr_list = list(bfr.split(',\n')) aft_list = list(aft.split(',\n')) - diffs = context_diff(aft_list, bfr_list, - fromfile='after_config', - tofile='before_config') + diffs = context_diff(bfr_list, aft_list, + fromfile='before_config', + tofile='after_config') formatted_diff = list() for diff in diffs: if diff.endswith('\n'):