Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playbook check and diff modes util and radius-server implemetation #279

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Playbook check and diff modes util and radius-server implemetation #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
16fa880
Playbook check and diff modes util and radius-server implemetation
mingjunzhang2019 Jul 7, 2023
53b011c
Add fragment file
mingjunzhang2019 Jul 7, 2023
ecbcabd
Fix sanity errors
mingjunzhang2019 Jul 7, 2023
5f69b72
Address review comments
mingjunzhang2019 Jul 12, 2023
a932062
Address review comment
mingjunzhang2019 Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/279-playbook-check-diff-modes-and-radius-server-implement.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
major_changes:
- Playbook check and diff modes utility functions and sonic_radius_server module support for the check and diff modes (https://github.com/ansible-collections/dellemc.enterprise_sonic/pull/279).
18 changes: 18 additions & 0 deletions plugins/module_utils/network/sonic/config/radius_server/radius_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,20 @@
get_replaced_config,
normalize_interface_name,
)
from ansible_collections.dellemc.enterprise_sonic.plugins.module_utils.network.sonic.utils.formatted_diff_utils import (
__DELETE_CONFIG_IF_NO_SUBCONFIG,
get_new_config,
get_formatted_config_diff
)

PATCH = 'patch'
DELETE = 'delete'
TEST_KEYS = [
{'host': {'name': ''}},
]
TEST_KEYS_formatted_diff = [
{'host': {'name': '', '__delete_op': __DELETE_CONFIG_IF_NO_SUBCONFIG}},
]


class Radius_server(ConfigBase):
Expand Down Expand Up @@ -92,6 +100,16 @@ def execute_module(self):
if result['changed']:
result['after'] = changed_radius_server_facts

new_config = changed_radius_server_facts
if self._module.check_mode:
result.pop('after', None)
new_config = get_new_config(commands, existing_radius_server_facts,
TEST_KEYS_formatted_diff)
result['after(generated)'] = new_config

if self._module._diff:
result['config_diff'] = get_formatted_config_diff(existing_radius_server_facts,
new_config)
result['warnings'] = warnings
return result

Expand Down
Loading