Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bgp_communities facts handling for empty member lists. #319

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Fix bgp_communities facts handling for empty member lists. #319

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86b5ea8
Fix bgp_communities facts handling for empty member lists.
kerry-meyer Dec 30, 2023
a0a3afa
Add a changelog fragment file for this fix.
kerry-meyer Dec 30, 2023
8820934
Corrected the tense for this changelog fragment.
kerry-meyer Jan 2, 2024
c855c3e
Added details for this changelog fragment.
kerry-meyer Jan 2, 2024
7505831
Add automated unit and integration testing for empty bgp community me…
kerry-meyer Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/319-bgp-communities-no-member-facts-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- Fix incorrect "facts" handling for parsing of a BGP community list configured with an empty "members" list (https://github.com/ansible-collections/dellemc.enterprise_sonic/pull/319).
11 changes: 7 additions & 4 deletions plugins/module_utils/network/sonic/facts/bgp_communities/bgp_communities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,14 @@ def get_bgp_communities(self):
result['permit'] = True
if members:
result['type'] = 'expanded' if 'REGEX' in members[0] else 'standard'
if result['type'] == 'expanded':
members = [':'.join(i.split(':')[1:]) for i in members]
members.sort()
result['members'] = {'regex': members}
if result['type'] == 'expanded':
members = [':'.join(i.split(':')[1:]) for i in members]
members.sort()
result['members'] = {'regex': members}
else:
result['type'] = 'standard'

if result['type'] == 'standard':
result['local_as'] = None
result['no_advertise'] = None
result['no_export'] = None
Expand Down