From 613081d2b2a266b86ca420f05aacb6ab7197774c Mon Sep 17 00:00:00 2001 From: Gregor Berginc Date: Fri, 18 Aug 2023 19:00:25 +0200 Subject: [PATCH 1/3] Rename msg parameter in assert Previously used msg parameter is now replaced with the new fail_msg. Signed-off-by: Gregor Berginc --- tasks/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tasks/main.yml b/tasks/main.yml index c96e9e5..4435910 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -27,7 +27,7 @@ - name: Check ansible version ansible.builtin.assert: that: ansible_version.full is version_compare(min_ansible_version, '>=') - msg: You must use Ansible {{ min_ansible_version }} or greater + fail_msg: You must use Ansible {{ min_ansible_version }} or greater tags: - always From a9dcf9e494c7cc012d55f0195f0a442947f6d9fe Mon Sep 17 00:00:00 2001 From: Gregor Berginc Date: Fri, 18 Aug 2023 19:01:50 +0200 Subject: [PATCH 2/3] Fix profile parameter in win_firewall According to the documentation, the parameter to speciffy the profile should be named profiles (plural), even if there is just one profile. This patch replaces two occurrences. Signed-off-by: Gregor Berginc --- tasks/section09.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tasks/section09.yml b/tasks/section09.yml index 0dd5595..593afcf 100644 --- a/tasks/section09.yml +++ b/tasks/section09.yml @@ -115,7 +115,7 @@ - name: "SCORED | 9.2.1 | PATCH | (L1) Ensure 'Windows Firewall: Private: Firewall state' is set to 'On (recommended)'" community.windows.win_firewall: state: enabled - profile: Private + profiles: Private when: - win16cis_rule_9_2_1 tags: @@ -226,7 +226,7 @@ - name: "SCORED | 9.3.1 | PATCH | (L1) Ensure 'Windows Firewall: Public: Firewall state' is set to 'On (recommended)'" community.windows.win_firewall: state: enabled - profile: Public + profiles: Public when: - win16cis_rule_9_3_1 tags: From 15277934ef3e3ef0a0979ec073dfdd623c6991a7 Mon Sep 17 00:00:00 2001 From: Gregor Berginc Date: Tue, 22 Aug 2023 14:50:43 +0200 Subject: [PATCH 3/3] win_regedit parameter renamed According to the documentation, the new parameters are name (instead of value) and type (instead of datatype). This patch renames these occurrences. Signed-off-by: Gregor Berginc --- tasks/section18.yml | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/tasks/section18.yml b/tasks/section18.yml index e1af77f..eda7198 100644 --- a/tasks/section18.yml +++ b/tasks/section18.yml @@ -218,9 +218,9 @@ ansible.windows.win_regedit: path: HKLM:\SYSTEM\CurrentControlSet\Services\NetBT\Parameters state: present - value: NodeType + name: NodeType data: 2 - datatype: dword + type: dword when: - win16cis_rule_18_3_6 tags: @@ -233,9 +233,9 @@ ansible.windows.win_regedit: path: HKLM:\SYSTEM\CurrentControlSet\Control\SecurityProviders\Wdigest state: present - value: UseLogonCredential + name: UseLogonCredential data: 0 - datatype: dword + type: dword when: - win16cis_rule_18_3_7 tags: @@ -248,9 +248,9 @@ ansible.windows.win_regedit: path: HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Winlogon state: present - value: AutoAdminLogon + name: AutoAdminLogon data: 0 - datatype: string + type: string when: - win16cis_rule_18_4_1 tags: @@ -263,9 +263,9 @@ ansible.windows.win_regedit: path: HKLM:\SYSTEM\CurrentControlSet\Services\Tcpip6\Parameters state: present - value: DisableIPSourceRouting + name: DisableIPSourceRouting data: 2 - datatype: dword + type: dword when: - win16cis_rule_18_4_2 tags: @@ -278,9 +278,9 @@ ansible.windows.win_regedit: path: HKLM:\SYSTEM\CurrentControlSet\Services\Tcpip\Parameters state: present - value: DisableIPSourceRouting + name: DisableIPSourceRouting data: 2 - datatype: dword + type: dword when: - win16cis_rule_18_4_3 tags: @@ -293,9 +293,9 @@ ansible.windows.win_regedit: path: HKLM:\SYSTEM\CurrentControlSet\Services\Tcpip\Parameters state: present - value: EnableICMPRedirect + name: EnableICMPRedirect data: 0 - datatype: dword + type: dword when: - win16cis_rule_18_4_4 tags: @@ -308,9 +308,9 @@ ansible.windows.win_regedit: path: HKLM:\SYSTEM\CurrentControlSet\Services\Tcpip\Parameters state: present - value: KeepAliveTime + name: KeepAliveTime data: 300000 - datatype: dword + type: dword when: - win16cis_rule_18_4_5 tags: