Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable django flags support #15660

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

feat: enable django flags support #15660

wants to merge 2 commits into from

Conversation

pb82
Copy link
Contributor

@pb82 pb82 commented Nov 25, 2024

SUMMARY

Enable support for django flags.

Verification steps:

  1. Start AWX locally
  2. Start a bash shell in the container: docker exec -it tools_awx_1 /bin/bash
  3. Set a test flag: python manage.py disable_flag TEST_FLAG
  4. Add the following code to one of the views (e.g. the ping view):
from flags.state import flag_state
print(flat_state('TEST_FLAG'))

  1. ensure that the value True is printed when accessing the route for the view
  2. Disable the flag: python manage.py disable_flag TEST_FLAG
  3. ensure that the value False is printed
ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API
AWX VERSION
devel
ADDITIONAL INFORMATION

@github-actions github-actions bot added component:api dependencies Pull requests that update a dependency file community labels Nov 25, 2024
@@ -23,7 +23,6 @@ asgiref==3.7.2
# channels-redis
# daphne
# django
# django-ansible-base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are still dependencies of DAB. They were added somewhat recently.

https://github.com/ansible/django-ansible-base/blob/devel/requirements/requirements_resource_registry.in

You probably generated this output incorrectly by using an outdated container image.

I also don't understand why we would add a dependency before we make any use of this dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanCoding I made sure to pull the latest changes and rebuild the container image. But after running ./updater run I still end up with the django-ansible-base comments removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community component:api dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants