-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small nit #15
Comments
@DataAnalysisCosby Your simplification looks better in this case. I'm guessing the reasoning behind this structure it is probably to keep it consistent with the other usages of
|
@DataAnalysisCosby @practicalswift I would also agree that this simplification is an improvement. It also makes the purpose of the code much more clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there, I don't really want to make a pull request here so I thought I'd just make an issue. Sorry if that's not proper etiquette! By the way, love the work.
The following lines of code appear in the source code:
Surely this should be simplified slightly to:
It seems a little off to make the conditional based off of the result of another conditional that appears literally one line above.
The text was updated successfully, but these errors were encountered: