Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"\t//" crashes kilo (sometimes!) #18

Open
1-p opened this issue Jul 12, 2016 · 4 comments
Open

"\t//" crashes kilo (sometimes!) #18

1-p opened this issue Jul 12, 2016 · 4 comments

Comments

@1-p
Copy link

1-p commented Jul 12, 2016 •
edited
Loading

to reproduce, start a new line, hit TAB, then / twice.

or hit / twice and then TAB at the beginning of the line.

Segmentation fault: 11

Seems like the while(*p) loop in editorUpdateSyntax has some bug.

https://github.com/antirez/kilo/blob/master/kilo.c#L401
@1-p 1-p mentioned this issue Jul 12, 2016
Open
@practicalswift
Copy link

@1-p Thanks for reporting! :-) Are you able to reproduce this? What platform are you using?

I'm unable to reproduce. I've tested under both Linux and OS X.

@Ruk33
Copy link

Ruk33 commented Jul 12, 2016 •
edited
Loading

I was able to reproduce it (Linux, Elementary OS). The PR solves it though.

@Alykoff
Copy link

Alykoff commented Jul 12, 2016 •
edited
Loading

It is reproducing for me too. OS X. Always.

@1-p
Copy link
Author

1-p commented Jul 16, 2016

@practicalswift Well, do it in a new line and enter \t//

It's due to a negative memset argument, as I said. And the PR I submitted fixed it. (changed a single char)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Ruk33 @Alykoff @practicalswift @1-p