Skip to content
This repository has been archived by the owner on Jun 21, 2018. It is now read-only.

Make Java installations ensurable (present/absent) #28

Open
staylorx opened this issue Nov 11, 2016 · 1 comment
Open

Make Java installations ensurable (present/absent) #28

staylorx opened this issue Nov 11, 2016 · 1 comment
Assignees

Comments

@staylorx
Copy link

I expected an 'ensure' parameter but didn't find one. Nice-to-have.

And again, thank you for the module.

@antoineco
Copy link
Owner

Indeed, I've seen this pattern a while ago, some people used to state entire modules should be ensurable, some others disagreed. In general I would agree with the idea as long as it doesn't introduce some unnecessary complexity (e.g. forcing the module to get split in "installer" and "uninstaller" classes.

Also this module includes some archive extraction for the tag.gz installation type, and the opposite of an archive extraction is a directory deletion, so we have to make sure we delete the right directory and not some extra files :) Puppet's https://docs.puppet.com/puppet/latest/reference/types/tidy.html resource can certainly do that.

Once again I'm open to suggestions.

@antoineco antoineco self-assigned this Nov 11, 2016
@antoineco antoineco changed the title Would be nice to have an 'ensure => present/absent' Make Java installations ensurable (present/absent) Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants