Skip to content

Latest commit

 

History

History
48 lines (34 loc) · 2.43 KB

feedback.md

File metadata and controls

48 lines (34 loc) · 2.43 KB

Video Store API

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Practices git with at least 10 small commits and meaningful commit messages ✔️?
Understands the importance of how APIs handle invalid/erroneous data in their reflection questions ✔️?
Practices Rails best practices and well-designed separation, and encapsulates business logic around check-out and check-in in models ✔️?
Uses controller tests to ensure quality code for every route, and checks for response status and content, with positive cases and negative cases ✔️?
Uses controller tests to ensure correctness for check out and check in requirement, and that checked out counts and inventories appropriately change ✔️?

Functional Requirements

Functional Requirement yes/no
All provided smoke tests for Wave 1 pass ✔️?
All provided smoke tests for Wave 2 pass ✔️?

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 3+ in Code Review && 2 in Functional Requirements
Yellow (Approaches Standards) 2+ in Code Review && 1+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-1 in Code Review or 0 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized