Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose speed / high compression option #279

Open
Awendel opened this issue Sep 25, 2022 · 2 comments
Open

expose speed / high compression option #279

Awendel opened this issue Sep 25, 2022 · 2 comments

Comments

@Awendel
Copy link

Awendel commented Sep 25, 2022

I saw that the original library supports passing on a speed / compression strength option.

It's mainly affects compression speed and has the classic tradeoff between compression strength and cpu cycles spend.
Decompression speed shouldn't be affected

Would maybe be nice to also add this to the library.

API could be set to the following:

compressSync(input:buffer, compressionLevel?:number, dict?:Buffer)

so that the latter are both optional but set to fastest by default (0 I beliebe)

@antoniomuso
Copy link
Owner

The current library used doesn't support this feature for now.

@Awendel
Copy link
Author

Awendel commented Sep 26, 2022

Ah, I see, since it's dependent on the Rust implementation.

So this seems to be the blocking issue for now:

PSeitz/lz4_flex#21

and if it's fixed there, one could also incorporate it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants