Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Halt does not work well with compose #3

Open
thec0keman opened this issue Jul 28, 2020 · 1 comment
Open

Using Halt does not work well with compose #3

thec0keman opened this issue Jul 28, 2020 · 1 comment

Comments

@thec0keman
Copy link

If service A calls service B with compose, and service B uses halt!, the errors from B are not passed to A.

I think this may be because the catch for the strict error exception doesn't handle anything. Perhaps it would work to use the ActiveInteraction Interrupt exception instead, since this is properly handled?

@antulik
Copy link
Owner

antulik commented Aug 7, 2020

Good find. We potentially could use Interrupt, there are two parts that concern me:

  • exceptions shouldn't be used for control flow, as they are slower
  • my understanding getting backtrace is also heavy operation, which we don't need in halt behaviour.

if your PR AaronLasseigne/active_interaction#486 won't be accepted, I think exception is the only way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants