Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins link to image of pin card instead of repo or gist. #3955

Open
kupietools opened this issue Sep 28, 2024 · 2 comments
Open

Pins link to image of pin card instead of repo or gist. #3955

kupietools opened this issue Sep 28, 2024 · 2 comments
Labels
bug Something isn't working.

Comments

@kupietools
Copy link

kupietools commented Sep 28, 2024

Describe the bug

I am using the pin and gist endpoints. While these do correctly render what looks like cards for pinned repos and gists, clicking on those cards opens an image of the card on the url "https://camo.githubusercontent.com/[long string of numbers]", rather than going to the repo or gist. This makes the pins unusable as a replacement for the native pins, which allow users to directly open repos.

At present,

Expected behavior

Clicking a card for a repo or gist should go to the page for that repo or gist.

Screenshots / Live demo link

As an example, here is a pin for a repo:

Readme Card

Here is a screenshot of what currently opens when I click that card:

image

Additional context

No response

@kupietools kupietools added the bug Something isn't working. label Sep 28, 2024
@softy-dev
Copy link

softy-dev commented Sep 28, 2024

You can wrap them in link tags, no? And then they'd work as intended. Same for any other card.

@Adam-Thometz
Copy link

I could fix this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

3 participants