Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to use nock or similar #67

Open
newhouse opened this issue Oct 25, 2021 · 0 comments
Open

Refactor tests to use nock or similar #67

newhouse opened this issue Oct 25, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@newhouse
Copy link
Contributor

Experience working with this project has led me to the opinion that the testing suite could use some improvements. Particularly, the way we mock server responses is a bit contrived and confusing due to the way we're trying to deal with / simulate the node-fetch responses. We should just use nock or something similar to define the responses from a spoofed server, and let node-fetch do it's real thing.

@newhouse newhouse added the enhancement New feature or request label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant