Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable specific features via cli for solana-genesis #45

Open
gregcusack opened this issue May 31, 2024 · 0 comments
Open

Enable specific features via cli for solana-genesis #45

gregcusack opened this issue May 31, 2024 · 0 comments

Comments

@gregcusack
Copy link
Collaborator

v1.17 and v1.18 are incompatable with cluster_type == Development. All features are enabled by default. Specifically the feature timely_vote_credits in v1.17 is incompatable with v1.18. In fact, timely_vote_credits should not be turned on in v1.17 at all.

One way to fix this is to comment out the timely_vote_credits feature in (sdk/src/feature_set.rs)[https://github.com/anza-xyz/agave/blob/master/sdk/src/feature_set.rs#L822-L1020]. But the is cumbersome and doesn't allow much flexibility. Plus other developers have complained that enabling and disabling features to check compatibility between versions is a pain and time consuming. So we need a way to

  1. enable all features by default (already exists)
  2. pass in a set of features that should be activated, leaving all other features inactive
  3. pass in a set of features that should not be activated, leaving all other features active

This probably has to be done in agave repo.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant