From c94684613d3643550cec943339add7230d8ac4fe Mon Sep 17 00:00:00 2001 From: Daniel Standish <15932138+dstandish@users.noreply.github.com> Date: Fri, 20 Sep 2024 13:29:48 -0700 Subject: [PATCH] Reduce max length of pre-commit hooks (#42384) This is just to ensure that we get each hook on a single line when running in split pane on macbook pro 14". --- .pre-commit-config.yaml | 73 ++- contributing-docs/08_static_code_checks.rst | 564 +++++++++--------- .../ci/pre_commit/check_pre_commit_hooks.py | 2 +- 3 files changed, 325 insertions(+), 314 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 204ae2471863..a356de6dec21 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -24,7 +24,8 @@ repos: - repo: meta hooks: - id: identity - name: Print input to the static check hooks for troubleshooting + name: Print checked files + description: Print input to the static check hooks for troubleshooting - id: check-hooks-apply name: Check if all hooks apply to the repository - repo: https://github.com/thlorenz/doctoc.git @@ -65,7 +66,7 @@ repos: - --fuzzy-match-generates-todo files: \.rst$ - id: insert-license - name: Add license for all CSS/JS/JSX/PUML/TS/TSX files + name: Add license for CSS/JS/JSX/PUML/TS/TSX files: \.(css|jsx?|puml|tsx?)$ exclude: ^\.github/.*$|^.*/.*_vendor/|^airflow/www/static/js/types/api-generated.ts$|ui/openapi-gen/ args: @@ -229,7 +230,7 @@ repos: rev: 1.18.0 hooks: - id: blacken-docs - name: Run black on Python code blocks in documentation files + name: Run black on docs args: - --line-length=110 - --target-version=py37 @@ -246,7 +247,7 @@ repos: - id: debug-statements name: Detect accidentally committed debug statements - id: check-builtin-literals - name: Require literal syntax when initializing builtin types + name: Require literal syntax when initializing builtins exclude: ^.*/.*_vendor/ - id: detect-private-key name: Detect if private key is added to the repository @@ -315,7 +316,8 @@ repos: rev: v2.3.0 hooks: - id: codespell - name: Run codespell to check for common misspellings in files + name: Run codespell + description: Run codespell to check for common misspellings in files entry: bash -c 'echo "If you think that this failure is an error, consider adding the word(s) to the codespell dictionary at docs/spelling_wordlist.txt. The word(s) should be in lowercase." && exec codespell "$@"' -- @@ -336,7 +338,8 @@ repos: # to be applied before the non-local pre-commits are run hooks: - id: validate-operators-init - name: Prevent templated field logic checks in operators' __init__ + name: No templated field logic checks in operator __init__ + description: Prevent templated field logic checks in operators' __init__ language: python entry: ./scripts/ci/pre_commit/validate_operators_init.py pass_filenames: true @@ -353,7 +356,7 @@ repos: additional_dependencies: ["ruff==0.5.5"] exclude: ^.*/.*_vendor/|^tests/dags/test_imports.py|^performance/tests/test_.*.py - id: ruff-format - name: Run 'ruff format' for extremely fast Python formatting + name: Run 'ruff format' description: "Run 'ruff format' for extremely fast Python formatting" entry: ./scripts/ci/pre_commit/ruff_format.py language: python @@ -404,7 +407,7 @@ repos: entry: ./scripts/ci/pre_commit/check_common_compat_used_for_openlineage.py additional_dependencies: ['rich>=12.4.4'] - id: check-airflow-providers-bug-report-template - name: Check airflow-bug-report provider list is sorted/unique + name: Sort airflow-bug-report provider list language: python files: ^.github/ISSUE_TEMPLATE/airflow_providers_bug_report\.yml$ require_serial: true @@ -426,7 +429,8 @@ repos: files: ^airflow/providers/.*\.py$ additional_dependencies: ['rich>=12.4.4'] - id: check-google-re2-as-dependency - name: Check google-re2 is declared as dependency when needed + name: Check google-re2 declared as dep + description: Check google-re2 is declared as dependency when needed entry: ./scripts/ci/pre_commit/check_google_re2_imports.py language: python pass_filenames: true @@ -441,7 +445,8 @@ repos: pass_filenames: false additional_dependencies: ['rich>=12.4.4'] - id: check-sql-dependency-common-data-structure - name: Check dependency of SQL Providers with common data structure + name: Check dependency of SQL providers + description: Check dependency of SQL Providers with common data structure entry: ./scripts/ci/pre_commit/check_common_sql_dependency.py language: python files: ^airflow/providers/.*/hooks/.*\.py$ @@ -508,7 +513,7 @@ repos: ^airflow/utils/db.py$ additional_dependencies: ['packaging','google-re2'] - id: update-version - name: Update version to the latest version in the documentation + name: Update versions in docs entry: ./scripts/ci/pre_commit/update_versions.py language: python files: ^docs|^airflow/__init__.py$ @@ -521,7 +526,7 @@ repos: pass_filenames: true files: \.py$ - id: check-links-to-example-dags-do-not-use-hardcoded-versions - name: Verify example dags do not use hard-coded version numbers + name: Verify no hard-coded version in example dags description: The links to example dags should use |version| as version specification language: pygrep entry: > @@ -661,13 +666,13 @@ repos: pass_filenames: false files: ^airflow/models/(?:base|mapped)operator\.py$ - id: check-init-decorator-arguments - name: Check model __init__ and decorator arguments are in sync + name: Sync model __init__ and decorator arguments language: python entry: ./scripts/ci/pre_commit/sync_init_decorator.py pass_filenames: false files: ^airflow/models/dag\.py$|^airflow/(?:decorators|utils)/task_group\.py$ - id: check-template-context-variable-in-sync - name: Check all template context variable references are in sync + name: Sync template context variable refs language: python entry: ./scripts/ci/pre_commit/template_context_key_sync.py files: ^airflow/models/taskinstance\.py$|^airflow/utils/context\.pyi?$|^docs/apache-airflow/templates-ref\.rst$ @@ -751,14 +756,14 @@ repos: pass_filenames: true - id: check-daysago-import-from-utils language: pygrep - name: Make sure days_ago is imported from airflow.utils.dates + name: days_ago imported from airflow.utils.dates entry: "(airflow\\.){0,1}utils\\.dates\\.days_ago" files: \.py$ exclude: ^.*/.*_vendor/ pass_filenames: true - id: check-start-date-not-used-in-defaults language: pygrep - name: start_date not to be defined in default_args in example_dags + name: start_date not in default_args entry: "default_args\\s*=\\s*{\\s*(\"|')start_date(\"|')|(\"|')start_date(\"|'):" files: \.*example_dags.*\.py$ exclude: ^.*/.*_vendor/ @@ -792,14 +797,14 @@ repos: pass_filenames: false require_serial: true - id: update-installed-providers-to-be-sorted - name: Sort alphabetically and uniquify installed_providers.txt + name: Sort and uniquify installed_providers.txt entry: ./scripts/ci/pre_commit/sort_installed_providers.py language: python files: ^\.pre-commit-config\.yaml$|^.*_installed_providers\.txt$ pass_filenames: false require_serial: true - id: update-spelling-wordlist-to-be-sorted - name: Sort alphabetically and uniquify spelling_wordlist.txt + name: Sort spelling_wordlist.txt entry: ./scripts/ci/pre_commit/sort_spelling_wordlist.py language: python files: ^\.pre-commit-config\.yaml$|^docs/spelling_wordlist\.txt$ @@ -895,7 +900,7 @@ repos: name: Validate hook IDs & names and sync with docs entry: ./scripts/ci/pre_commit/check_pre_commit_hooks.py args: - - --max-length=60 + - --max-length=53 language: python files: ^\.pre-commit-config\.yaml$|^scripts/ci/pre_commit/check_pre_commit_hooks\.py$ additional_dependencies: ['pyyaml', 'jinja2', 'black==23.10.0', 'tabulate', 'rich>=12.4.4'] @@ -925,7 +930,8 @@ repos: pass_filenames: false require_serial: true - id: check-breeze-top-dependencies-limited - name: Breeze should have small number of top-level dependencies + name: Check top-level breeze deps + description: Breeze should have small number of top-level dependencies language: python entry: ./scripts/tools/check_if_limited_dependencies.py files: ^dev/breeze/.*$ @@ -963,7 +969,7 @@ repos: files: \.(md|mdown|markdown)$ additional_dependencies: ['markdownlint-cli@0.38.0'] - id: lint-json-schema - name: Lint JSON Schema files with JSON Schema + name: Lint JSON Schema files entry: ./scripts/ci/pre_commit/json_schema.py args: - --spec-url @@ -975,7 +981,7 @@ repos: require_serial: true additional_dependencies: ['jsonschema>=3.2.0,<5.0', 'PyYAML==5.3.1', 'requests==2.25.0'] - id: lint-json-schema - name: Lint NodePort Service with JSON Schema + name: Lint NodePort Service entry: ./scripts/ci/pre_commit/json_schema.py args: - --spec-url @@ -986,7 +992,7 @@ repos: require_serial: true additional_dependencies: ['jsonschema>=3.2.0,<5.0', 'PyYAML==5.3.1', 'requests==2.25.0'] - id: lint-json-schema - name: Lint Docker compose files with JSON Schema + name: Lint Docker compose files entry: ./scripts/ci/pre_commit/json_schema.py args: - --spec-url @@ -1001,7 +1007,7 @@ repos: require_serial: true additional_dependencies: ['jsonschema>=3.2.0,<5.0', 'PyYAML==5.3.1', 'requests==2.25.0'] - id: lint-json-schema - name: Lint chart/values.schema.json file with JSON Schema + name: Lint chart/values.schema.json entry: ./scripts/ci/pre_commit/json_schema.py args: - --spec-file @@ -1019,7 +1025,7 @@ repos: files: ^chart/values\.schema\.json$ additional_dependencies: ['requests==2.25.0'] - id: lint-json-schema - name: Lint chart/values.yaml file with JSON Schema + name: Lint chart/values.yaml entry: ./scripts/ci/pre_commit/json_schema.py args: - --enforce-defaults @@ -1032,7 +1038,7 @@ repos: require_serial: true additional_dependencies: ['jsonschema>=3.2.0,<5.0', 'PyYAML==5.3.1', 'requests==2.25.0'] - id: lint-json-schema - name: Lint config_templates/config.yml file with JSON Schema + name: Lint config_templates/config.yml entry: ./scripts/ci/pre_commit/json_schema.py args: - --spec-file @@ -1043,7 +1049,8 @@ repos: require_serial: true additional_dependencies: ['jsonschema>=3.2.0,<5.0', 'PyYAML==5.3.1', 'requests==2.25.0'] - id: check-persist-credentials-disabled-in-github-workflows - name: Check that workflow files have persist-credentials disabled + name: Check persistent creds in workflow files + description: Check that workflow files have persist-credentials disabled entry: ./scripts/ci/pre_commit/checkout_no_credentials.py language: python pass_filenames: true @@ -1108,7 +1115,8 @@ repos: # This is fast, so not too much downside always_run: true - id: update-breeze-cmd-output - name: Update output of breeze commands in Breeze documentation + name: Update breeze docs + description: Update output of breeze commands in Breeze documentation entry: ./scripts/ci/pre_commit/breeze_cmd_line.py language: python files: > @@ -1151,7 +1159,8 @@ repos: pass_filenames: false files: ^tests/.*\.py$ - id: ts-compile-format-lint-www - name: TS types generation / ESLint / Prettier against UI files + name: Compile / format / lint WWW + description: TS types generation / ESLint / Prettier against UI files language: node 'types_or': [javascript, ts, tsx, yaml, css, json] files: ^airflow/www/static/(js|css)/|^airflow/api_connexion/openapi/v1\.yaml$ @@ -1159,7 +1168,8 @@ repos: additional_dependencies: ['yarn@1.22.21', "openapi-typescript@>=6.7.4"] pass_filenames: false - id: ts-compile-format-lint-ui - name: TS types generation / ESLint / Prettier new UI files + name: Compile / format / lint UI + description: TS types generation / ESLint / Prettier new UI files language: node types_or: [javascript, ts, tsx, yaml, css, json] files: ^airflow/ui/|^airflow/api_connexion/openapi/v1\.yaml$ @@ -1167,7 +1177,8 @@ repos: additional_dependencies: ['pnpm@9.7.1'] pass_filenames: false - id: check-tests-unittest-testcase - name: Check that unit tests do not inherit from unittest.TestCase + name: Unit tests do not inherit from unittest.TestCase + description: Check that unit tests do not inherit from unittest.TestCase entry: ./scripts/ci/pre_commit/unittest_testcase.py language: python pass_filenames: true diff --git a/contributing-docs/08_static_code_checks.rst b/contributing-docs/08_static_code_checks.rst index 0f2acf890bb5..0a3dcacd9e07 100644 --- a/contributing-docs/08_static_code_checks.rst +++ b/contributing-docs/08_static_code_checks.rst @@ -113,288 +113,288 @@ require Breeze Docker image to be built locally. .. BEGIN AUTO-GENERATED STATIC CHECK LIST -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| ID | Description | Image | -+===========================================================+==============================================================+=========+ -| bandit | bandit | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| blacken-docs | Run black on Python code blocks in documentation files | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-aiobotocore-optional | Check if aiobotocore is an optional dependency only | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-airflow-k8s-not-used | Check airflow.kubernetes imports are not used | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-airflow-provider-compatibility | Check compatibility of Providers with Airflow | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-airflow-providers-bug-report-template | Check airflow-bug-report provider list is sorted/unique | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-apache-license-rat | Check if licenses are OK for Apache | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-base-operator-partial-arguments | Check BaseOperator and partial() arguments | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-base-operator-usage | * Check BaseOperator core imports | | -| | * Check BaseOperatorLink core imports | | -| | * Check BaseOperator[Link] other imports | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-boring-cyborg-configuration | Checks for Boring Cyborg configuration consistency | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-breeze-top-dependencies-limited | Breeze should have small number of top-level dependencies | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-builtin-literals | Require literal syntax when initializing builtin types | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-changelog-format | Check changelog format | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-changelog-has-no-duplicates | Check changelogs for duplicate entries | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-cncf-k8s-only-for-executors | Check cncf.kubernetes imports used for executors only | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-code-deprecations | Check deprecations categories in decorators | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-common-compat-used-for-openlineage | Check common.compat is used for OL deprecated classes | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-compat-cache-on-methods | Check that compat cache do not use on class methods | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-core-deprecation-classes | Verify usage of Airflow deprecation classes in core | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-daysago-import-from-utils | Make sure days_ago is imported from airflow.utils.dates | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-decorated-operator-implements-custom-name | Check @task decorator implements custom_operator_name | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-deferrable-default | Check and fix default value of default_deferrable | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-docstring-param-types | Check that docstrings do not specify param types | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-example-dags-urls | Check that example dags url include provider versions | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-executables-have-shebangs | Check that executables have shebang | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-extra-packages-references | Checks setup extra packages | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-extras-order | Check order of extras in Dockerfile | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-fab-migrations | Check no migration is done on FAB related table | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-for-inclusive-language | Check for language that we do not accept as community | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-get-lineage-collector-providers | Check providers import hook lineage code from compat | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-google-re2-as-dependency | Check google-re2 is declared as dependency when needed | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-hatch-build-order | Check order of dependencies in hatch_build.py | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-hooks-apply | Check if all hooks apply to the repository | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-incorrect-use-of-LoggingMixin | Make sure LoggingMixin is not used alone | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-init-decorator-arguments | Check model __init__ and decorator arguments are in sync | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-integrations-list-consistent | Sync integrations list with docs | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-lazy-logging | Check that all logging methods are lazy | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-links-to-example-dags-do-not-use-hardcoded-versions | Verify example dags do not use hard-coded version numbers | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-merge-conflict | Check that merge conflicts are not being committed | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-newsfragments-are-valid | Check newsfragments are valid | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-no-airflow-deprecation-in-providers | Do not use DeprecationWarning in providers | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-no-providers-in-core-examples | No providers imports in core example DAGs | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-only-new-session-with-provide-session | Check NEW_SESSION is only used with @provide_session | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-persist-credentials-disabled-in-github-workflows | Check that workflow files have persist-credentials disabled | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-pre-commit-information-consistent | Validate hook IDs & names and sync with docs | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-provide-create-sessions-imports | Check provide_session and create_session imports | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-provider-docs-valid | Validate provider doc files | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-provider-yaml-valid | Validate provider.yaml files | * | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-providers-init-file-missing | Provider init file is missing | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-providers-subpackages-init-file-exist | Provider subpackage init files are there | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-pydevd-left-in-code | Check for pydevd debug statements accidentally left | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-revision-heads-map | Check that the REVISION_HEADS_MAP is up-to-date | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-safe-filter-usage-in-html | Don't use safe in templates | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-sql-dependency-common-data-structure | Check dependency of SQL Providers with common data structure | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-start-date-not-used-in-defaults | start_date not to be defined in default_args in example_dags | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-system-tests-present | Check if system tests have required segments of code | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-system-tests-tocs | Check that system tests is properly added | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-taskinstance-tis-attrs | Check that TI and TIS have the same attributes | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-template-context-variable-in-sync | Check all template context variable references are in sync | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-tests-in-the-right-folders | Check if tests are in the right folders | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-tests-unittest-testcase | Check that unit tests do not inherit from unittest.TestCase | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-urlparse-usage-in-code | Don't use urlparse in code | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-usage-of-re2-over-re | Use re2 module instead of re | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| check-xml | Check XML files with xmllint | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| codespell | Run codespell to check for common misspellings in files | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| compile-ui-assets | Compile ui assets (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| compile-ui-assets-dev | Compile ui assets in dev mode (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| compile-www-assets | Compile www assets (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| compile-www-assets-dev | Compile www assets in dev mode (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| create-missing-init-py-files-tests | Create missing init.py files in tests | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| debug-statements | Detect accidentally committed debug statements | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| detect-private-key | Detect if private key is added to the repository | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| doctoc | Add TOC for Markdown and RST files | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| end-of-file-fixer | Make sure that there is an empty line at the end | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| fix-encoding-pragma | Remove encoding header from Python files | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| flynt | Run flynt string format converter for Python | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| generate-airflow-diagrams | Generate airflow diagrams | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| generate-openapi-spec | Generate the FastAPI API spec | * | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| generate-pypi-readme | Generate PyPI README | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| identity | Print input to the static check hooks for troubleshooting | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| insert-license | * Add license for all SQL files | | -| | * Add license for all RST files | | -| | * Add license for all CSS/JS/JSX/PUML/TS/TSX files | | -| | * Add license for all JINJA template files | | -| | * Add license for all Shell files | | -| | * Add license for all toml files | | -| | * Add license for all Python files | | -| | * Add license for all XML files | | -| | * Add license for all Helm template files | | -| | * Add license for all YAML files except Helm templates | | -| | * Add license for all Markdown files | | -| | * Add license for all other files | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| kubeconform | Kubeconform check on our helm chart | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| lint-chart-schema | Lint chart/values.schema.json file | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| lint-css | stylelint | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| lint-dockerfile | Lint Dockerfile | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| lint-helm-chart | Lint Helm Chart | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| lint-json-schema | * Lint JSON Schema files with JSON Schema | | -| | * Lint NodePort Service with JSON Schema | | -| | * Lint Docker compose files with JSON Schema | | -| | * Lint chart/values.schema.json file with JSON Schema | | -| | * Lint chart/values.yaml file with JSON Schema | | -| | * Lint config_templates/config.yml file with JSON Schema | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| lint-markdown | Run markdownlint | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| lint-openapi | * Lint OpenAPI using spectral | | -| | * Lint OpenAPI using openapi-spec-validator | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| mixed-line-ending | Detect if mixed line ending is used (\r vs. \r\n) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| mypy-airflow | * Run mypy for airflow | * | -| | * Run mypy for airflow (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| mypy-dev | * Run mypy for dev | * | -| | * Run mypy for dev (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| mypy-docs | * Run mypy for /docs/ folder | * | -| | * Run mypy for /docs/ folder (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| mypy-providers | * Run mypy for providers | * | -| | * Run mypy for providers (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| pretty-format-json | Format JSON files | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| pylint | pylint | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| python-no-log-warn | Check if there are no deprecate log warn | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| replace-bad-characters | Replace bad characters | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| rst-backticks | Check if RST files use double backticks for code | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| ruff | Run 'ruff' for extremely fast Python linting | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| ruff-format | Run 'ruff format' for extremely fast Python formatting | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| shellcheck | Check Shell scripts syntax correctness | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| trailing-whitespace | Remove trailing whitespace at end of line | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| ts-compile-format-lint-ui | TS types generation / ESLint / Prettier new UI files | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| ts-compile-format-lint-www | TS types generation / ESLint / Prettier against UI files | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-black-version | Update black versions everywhere (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-breeze-cmd-output | Update output of breeze commands in Breeze documentation | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-breeze-readme-config-hash | Update Breeze README.md with config files hash | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-build-dependencies | Update build-dependencies to latest (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-chart-dependencies | Update chart dependencies to latest (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-common-sql-api-stubs | Check and update common.sql API stubs | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-er-diagram | Update ER diagram | * | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-extras | Update extras in documentation | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-in-the-wild-to-be-sorted | Sort INTHEWILD.md alphabetically | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-inlined-dockerfile-scripts | Inline Dockerfile and Dockerfile.ci scripts | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-installed-providers-to-be-sorted | Sort alphabetically and uniquify installed_providers.txt | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-installers | Update installers to latest (manual) | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-local-yml-file | Update mounts in the local yml file | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-migration-references | Update migration ref doc | * | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-openapi-spec-tags-to-be-sorted | Sort alphabetically openapi spec tags | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-providers-dependencies | Update dependencies for provider packages | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-reproducible-source-date-epoch | Update Source Date Epoch for reproducible builds | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-spelling-wordlist-to-be-sorted | Sort alphabetically and uniquify spelling_wordlist.txt | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-supported-versions | Updates supported versions in documentation | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-vendored-in-k8s-json-schema | Vendor k8s definitions into values.schema.json | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| update-version | Update version to the latest version in the documentation | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| validate-operators-init | Prevent templated field logic checks in operators' __init__ | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ -| yamllint | Check YAML files with yamllint | | -+-----------------------------------------------------------+--------------------------------------------------------------+---------+ ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| ID | Description | Image | ++===========================================================+========================================================+=========+ +| bandit | bandit | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| blacken-docs | Run black on docs | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-aiobotocore-optional | Check if aiobotocore is an optional dependency only | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-airflow-k8s-not-used | Check airflow.kubernetes imports are not used | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-airflow-provider-compatibility | Check compatibility of Providers with Airflow | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-airflow-providers-bug-report-template | Sort airflow-bug-report provider list | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-apache-license-rat | Check if licenses are OK for Apache | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-base-operator-partial-arguments | Check BaseOperator and partial() arguments | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-base-operator-usage | * Check BaseOperator core imports | | +| | * Check BaseOperatorLink core imports | | +| | * Check BaseOperator[Link] other imports | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-boring-cyborg-configuration | Checks for Boring Cyborg configuration consistency | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-breeze-top-dependencies-limited | Check top-level breeze deps | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-builtin-literals | Require literal syntax when initializing builtins | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-changelog-format | Check changelog format | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-changelog-has-no-duplicates | Check changelogs for duplicate entries | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-cncf-k8s-only-for-executors | Check cncf.kubernetes imports used for executors only | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-code-deprecations | Check deprecations categories in decorators | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-common-compat-used-for-openlineage | Check common.compat is used for OL deprecated classes | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-compat-cache-on-methods | Check that compat cache do not use on class methods | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-core-deprecation-classes | Verify usage of Airflow deprecation classes in core | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-daysago-import-from-utils | days_ago imported from airflow.utils.dates | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-decorated-operator-implements-custom-name | Check @task decorator implements custom_operator_name | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-deferrable-default | Check and fix default value of default_deferrable | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-docstring-param-types | Check that docstrings do not specify param types | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-example-dags-urls | Check that example dags url include provider versions | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-executables-have-shebangs | Check that executables have shebang | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-extra-packages-references | Checks setup extra packages | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-extras-order | Check order of extras in Dockerfile | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-fab-migrations | Check no migration is done on FAB related table | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-for-inclusive-language | Check for language that we do not accept as community | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-get-lineage-collector-providers | Check providers import hook lineage code from compat | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-google-re2-as-dependency | Check google-re2 declared as dep | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-hatch-build-order | Check order of dependencies in hatch_build.py | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-hooks-apply | Check if all hooks apply to the repository | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-incorrect-use-of-LoggingMixin | Make sure LoggingMixin is not used alone | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-init-decorator-arguments | Sync model __init__ and decorator arguments | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-integrations-list-consistent | Sync integrations list with docs | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-lazy-logging | Check that all logging methods are lazy | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-links-to-example-dags-do-not-use-hardcoded-versions | Verify no hard-coded version in example dags | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-merge-conflict | Check that merge conflicts are not being committed | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-newsfragments-are-valid | Check newsfragments are valid | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-no-airflow-deprecation-in-providers | Do not use DeprecationWarning in providers | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-no-providers-in-core-examples | No providers imports in core example DAGs | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-only-new-session-with-provide-session | Check NEW_SESSION is only used with @provide_session | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-persist-credentials-disabled-in-github-workflows | Check persistent creds in workflow files | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-pre-commit-information-consistent | Validate hook IDs & names and sync with docs | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-provide-create-sessions-imports | Check provide_session and create_session imports | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-provider-docs-valid | Validate provider doc files | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-provider-yaml-valid | Validate provider.yaml files | * | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-providers-init-file-missing | Provider init file is missing | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-providers-subpackages-init-file-exist | Provider subpackage init files are there | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-pydevd-left-in-code | Check for pydevd debug statements accidentally left | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-revision-heads-map | Check that the REVISION_HEADS_MAP is up-to-date | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-safe-filter-usage-in-html | Don't use safe in templates | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-sql-dependency-common-data-structure | Check dependency of SQL providers | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-start-date-not-used-in-defaults | start_date not in default_args | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-system-tests-present | Check if system tests have required segments of code | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-system-tests-tocs | Check that system tests is properly added | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-taskinstance-tis-attrs | Check that TI and TIS have the same attributes | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-template-context-variable-in-sync | Sync template context variable refs | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-tests-in-the-right-folders | Check if tests are in the right folders | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-tests-unittest-testcase | Unit tests do not inherit from unittest.TestCase | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-urlparse-usage-in-code | Don't use urlparse in code | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-usage-of-re2-over-re | Use re2 module instead of re | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| check-xml | Check XML files with xmllint | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| codespell | Run codespell | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| compile-ui-assets | Compile ui assets (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| compile-ui-assets-dev | Compile ui assets in dev mode (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| compile-www-assets | Compile www assets (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| compile-www-assets-dev | Compile www assets in dev mode (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| create-missing-init-py-files-tests | Create missing init.py files in tests | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| debug-statements | Detect accidentally committed debug statements | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| detect-private-key | Detect if private key is added to the repository | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| doctoc | Add TOC for Markdown and RST files | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| end-of-file-fixer | Make sure that there is an empty line at the end | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| fix-encoding-pragma | Remove encoding header from Python files | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| flynt | Run flynt string format converter for Python | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| generate-airflow-diagrams | Generate airflow diagrams | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| generate-openapi-spec | Generate the FastAPI API spec | * | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| generate-pypi-readme | Generate PyPI README | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| identity | Print checked files | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| insert-license | * Add license for all SQL files | | +| | * Add license for all RST files | | +| | * Add license for CSS/JS/JSX/PUML/TS/TSX | | +| | * Add license for all JINJA template files | | +| | * Add license for all Shell files | | +| | * Add license for all toml files | | +| | * Add license for all Python files | | +| | * Add license for all XML files | | +| | * Add license for all Helm template files | | +| | * Add license for all YAML files except Helm templates | | +| | * Add license for all Markdown files | | +| | * Add license for all other files | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| kubeconform | Kubeconform check on our helm chart | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| lint-chart-schema | Lint chart/values.schema.json file | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| lint-css | stylelint | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| lint-dockerfile | Lint Dockerfile | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| lint-helm-chart | Lint Helm Chart | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| lint-json-schema | * Lint JSON Schema files | | +| | * Lint NodePort Service | | +| | * Lint Docker compose files | | +| | * Lint chart/values.schema.json | | +| | * Lint chart/values.yaml | | +| | * Lint config_templates/config.yml | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| lint-markdown | Run markdownlint | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| lint-openapi | * Lint OpenAPI using spectral | | +| | * Lint OpenAPI using openapi-spec-validator | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| mixed-line-ending | Detect if mixed line ending is used (\r vs. \r\n) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| mypy-airflow | * Run mypy for airflow | * | +| | * Run mypy for airflow (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| mypy-dev | * Run mypy for dev | * | +| | * Run mypy for dev (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| mypy-docs | * Run mypy for /docs/ folder | * | +| | * Run mypy for /docs/ folder (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| mypy-providers | * Run mypy for providers | * | +| | * Run mypy for providers (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| pretty-format-json | Format JSON files | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| pylint | pylint | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| python-no-log-warn | Check if there are no deprecate log warn | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| replace-bad-characters | Replace bad characters | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| rst-backticks | Check if RST files use double backticks for code | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| ruff | Run 'ruff' for extremely fast Python linting | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| ruff-format | Run 'ruff format' | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| shellcheck | Check Shell scripts syntax correctness | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| trailing-whitespace | Remove trailing whitespace at end of line | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| ts-compile-format-lint-ui | Compile / format / lint UI | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| ts-compile-format-lint-www | Compile / format / lint WWW | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-black-version | Update black versions everywhere (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-breeze-cmd-output | Update breeze docs | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-breeze-readme-config-hash | Update Breeze README.md with config files hash | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-build-dependencies | Update build-dependencies to latest (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-chart-dependencies | Update chart dependencies to latest (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-common-sql-api-stubs | Check and update common.sql API stubs | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-er-diagram | Update ER diagram | * | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-extras | Update extras in documentation | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-in-the-wild-to-be-sorted | Sort INTHEWILD.md alphabetically | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-inlined-dockerfile-scripts | Inline Dockerfile and Dockerfile.ci scripts | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-installed-providers-to-be-sorted | Sort and uniquify installed_providers.txt | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-installers | Update installers to latest (manual) | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-local-yml-file | Update mounts in the local yml file | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-migration-references | Update migration ref doc | * | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-openapi-spec-tags-to-be-sorted | Sort alphabetically openapi spec tags | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-providers-dependencies | Update dependencies for provider packages | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-reproducible-source-date-epoch | Update Source Date Epoch for reproducible builds | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-spelling-wordlist-to-be-sorted | Sort spelling_wordlist.txt | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-supported-versions | Updates supported versions in documentation | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-vendored-in-k8s-json-schema | Vendor k8s definitions into values.schema.json | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| update-version | Update versions in docs | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| validate-operators-init | No templated field logic checks in operator __init__ | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ +| yamllint | Check YAML files with yamllint | | ++-----------------------------------------------------------+--------------------------------------------------------+---------+ .. END AUTO-GENERATED STATIC CHECK LIST diff --git a/scripts/ci/pre_commit/check_pre_commit_hooks.py b/scripts/ci/pre_commit/check_pre_commit_hooks.py index 727b4d4bc042..76d21980fea4 100755 --- a/scripts/ci/pre_commit/check_pre_commit_hooks.py +++ b/scripts/ci/pre_commit/check_pre_commit_hooks.py @@ -68,7 +68,7 @@ def get_errors_and_hooks(content: Any, max_length: int) -> tuple[list[str], dict name = hook["name"] if len(name) > max_length: errors.append( - f"Name is too long for hook `{hook_id}` in {PRE_COMMIT_YAML_FILE}. Please shorten it!" + f"Name is too long for hook `{name}` in {PRE_COMMIT_YAML_FILE}. Please shorten it!" ) continue hooks[hook_id].append(name)