AIP-84 Get Mapped Task Instance Tries #44303
Open
+761
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandharvishnu
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
ephraimbuddy
as code owners
boring-cyborg
bot
added
area:API
kandharvishnu
force-pushed
the
AIP-84_get_mapped_task_instance_tries
branch
from
1b5e318
to
3c81dd4
Compare
rawwar
reviewed
Nov 23, 2024
rawwar
reviewed
Nov 23, 2024
rawwar
reviewed
Nov 23, 2024
Comment on lines
+273
to
+279
| task_instances = [ | ||
| TaskInstanceHistoryResponse.model_validate(task_instance, from_attributes=True) | ||
| for task_instance in task_instance_select | ||
| ] | ||
| return TaskInstanceHistoryCollectionResponse( | ||
| task_instances=task_instances, | ||
| total_entries=len(task_instances), | ||
| ) |
There was a problem hiding this comment.
Suggested change
| task_instances = [ | |
| TaskInstanceHistoryResponse.model_validate(task_instance, from_attributes=True) | |
| for task_instance in task_instance_select | |
| ] | |
| return TaskInstanceHistoryCollectionResponse( | |
| task_instances=task_instances, | |
| total_entries=len(task_instances), | |
| ) | |
| return TaskInstanceHistoryCollectionResponse( | |
| task_instances=task_instance_select, | |
| total_entries=len(task_instance_select), | |
| ) |
There was a problem hiding this comment.
TaskInstanceHistoryCollectionResponse will take the list of TaskInstanceHistoryResponse.
As a first step, I am changing the airflow.models.taskinstance.TaskInstance to TaskInstanceHistoryResponse and then passing it to TaskInstanceHistoryCollectionResponse
There was a problem hiding this comment.
can you use cast like here:
There was a problem hiding this comment.
If this doesn't work. please close this conversation.
kandharvishnu
force-pushed
the
AIP-84_get_mapped_task_instance_tries
branch
from
3c81dd4
to
a22e190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #42370