Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX add error_cb to confluent.Consumer config in ConsumerFromTopic #44307

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FIX add error_cb to confluent.Consumer config in ConsumerFromTopic #44307

wants to merge 1 commit into from
+13 −0

Conversation

SuccessMoses
Copy link
Contributor

closes: #43569

@rawwar rawwar self-requested a review November 23, 2024 14:14
rawwar
rawwar reviewed Nov 23, 2024
View reviewed changes
providers/src/airflow/providers/apache/kafka/hooks/consume.py

def error_callback(err):
"""Handle kafka errors."""
print("Exception received: ", err)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we try to use logger instead of a print here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think in other operators they use logger instead

rawwar
rawwar reviewed Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@rawwar rawwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the approach looks good and similar to what I have tested. Please update tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawwar rawwar rawwar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:providers provider:apache-kafka
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConsumeFromTopicOperator does not fail even if wrong credentials are given
2 participants
@SuccessMoses @rawwar