Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo fmt doesn't properly work on parquet crate #6897

Open
alamb opened this issue Dec 18, 2024 · 1 comment
Open

cargo fmt doesn't properly work on parquet crate #6897

alamb opened this issue Dec 18, 2024 · 1 comment

Comments

@alamb
Copy link
Contributor

alamb commented Dec 18, 2024

Things like

arrow-rs/parquet/src/lib.rs

Lines 137 to 138 in 54dccad

experimental!(mod compression);
experimental!(mod encodings);
cause entire modules to be skipped by cargo fmt.

This means that the parquet code is not properly formatted the way most rust developers would expect

cargo fmt

@etseidl added commands that do actually format the parquet crate in CI

However it is confusing to know how to fix CI when it fails.

I agree the incantation is not desirable, and was meant to be a stop-gap until a better solution can be found.

Originally posted by @etseidl in #6886 (comment)

@etseidl
Copy link
Contributor

etseidl commented Dec 19, 2024

Root cause rust-lang/rustfmt#3253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants