Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev] Use "Gandiva" instead of "C++ - Gandiva" label #44223

Closed
kou opened this issue Sep 25, 2024 · 2 comments
Closed

[Dev] Use "Gandiva" instead of "C++ - Gandiva" label #44223

kou opened this issue Sep 25, 2024 · 2 comments
Assignees
@kou
Labels
Component: Developer Tools Type: enhancement
Milestone
19.0.0

Comments

@kou
Copy link
Member

kou commented Sep 25, 2024

Describe the enhancement requested

We're using "C++" and "C++ - Gandiva" labels in our templates like https://github.com/apache/arrow/blob/main/.github/ISSUE_TEMPLATE/bug_report.yaml .

Do we need "C++ - " in "C++ - Gandiva"? Can we remove the "C++ - " part and use "C++" and "Gandiva" labels instead of "C++ - Gandiva" label?

Component(s)

Developer Tools
@pitrou
Copy link
Member

pitrou commented Nov 13, 2024

I don't mind personally.

kou added a commit to kou/arrow that referenced this issue Nov 14, 2024
@kou
apacheGH-44223: [Dev] Use "Gandiva" instead of "C++ - Gandiva" label
03eaa54
@github-actions github-actions bot mentioned this issue Nov 14, 2024
Merged
raulcd pushed a commit that referenced this issue Nov 14, 2024
@kou
GH-44223: [Dev] Use "Gandiva" instead of "C++ - Gandiva" label (#44722)
26aa75f 
### Rationale for this change

We have Gandiva related codes. So "C++ -" isn't match the current code base.

### What changes are included in this PR?

Remove the "C++ - " part.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* GitHub Issue: #44223

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
@raulcd
Copy link
Member

raulcd commented Nov 14, 2024

Issue resolved by pull request 44722
#44722

@raulcd raulcd added this to the 19.0.0 milestone Nov 14, 2024
@raulcd raulcd closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Developer Tools Type: enhancement
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
3 participants
@kou @raulcd @pitrou