Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Flight integration tests don't include non-target implementations as producers #44479

Closed
adamreeve opened this issue Oct 21, 2024 · 1 comment
Closed

[CI] Flight integration tests don't include non-target implementations as producers #44479

adamreeve opened this issue Oct 21, 2024 · 1 comment
Assignees
@kou
Labels
Component: Integration Type: bug
Milestone
19.0.0

Comments

@adamreeve
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

See #44377 (comment)

The Archery Flight integration tests currently run the following combinations (eg. see https://github.com/apache/arrow/actions/runs/11285634070/job/31388753091):

Integration: Test: Flight: C++ -> C++
Integration: Test: Flight: C++ -> Java
Integration: Test: Flight: C++ -> C#
Integration: Test: Flight: C++ -> Go
Integration: Test: Flight: C++ -> Rust
Integration: Test: Flight: Java -> C++
Integration: Test: Flight: Java -> Java
Integration: Test: Flight: Java -> C#
Integration: Test: Flight: Java -> Go
Integration: Test: Flight: Java -> Rust
Integration: Test: Flight: C# -> C++
Integration: Test: Flight: C# -> Java
Integration: Test: Flight: C# -> C#
Integration: Test: Flight: C# -> Go
Integration: Test: Flight: C# -> Rust

This is missing running Go and Rust as producers with the three target implementations as clients.

Component(s)

Integration
@adamreeve adamreeve mentioned this issue Oct 21, 2024
Merged
kou added a commit to kou/arrow that referenced this issue Nov 11, 2024
@kou
apacheGH-44479: [CI][Archery] Add missing Flight integration targets
8adad75
@github-actions github-actions bot mentioned this issue Nov 11, 2024
Merged
kou added a commit that referenced this issue Nov 14, 2024
@kou
GH-44479: [CI][Archery] Add missing Flight integration targets (#44691)
65f498b 
### Rationale for this change

Go, Rust -> C++, Java, C# don't exist.

### What changes are included in this PR?

Add Go, Rust -> C++, Java, C# pairs.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.

* GitHub Issue: #44479

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 19.0.0 milestone Nov 14, 2024
@kou
Copy link
Member

kou commented Nov 14, 2024

Issue resolved by pull request 44691
#44691

@kou kou closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Integration Type: bug
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@kou @adamreeve