Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/Run error injector tests only for Debug build. #652

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

PengZheng
Copy link
Contributor

@PengZheng PengZheng commented Sep 24, 2023

Fix testing issue for non-debug build following the suggestion given here.

Note that for cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_TESTING=ON ..; make -j 8; ctest, there is still a test failure left:

The following tests FAILED:
         49 - test_cxx_remote_services_integration (SEGFAULT)

A separate issue is raised: #653

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2023

Codecov Report

Merging #652 (c0b7c34) into master (be8a413) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head c0b7c34 differs from pull request most recent head dc0e0ae. Consider uploading reports for the commit dc0e0ae to get more accurate results

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   81.59%   81.60%   +0.01%     
==========================================
  Files         260      260              
  Lines       34675    34675              
==========================================
+ Hits        28292    28296       +4     
+ Misses       6383     6379       -4     

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rlenferink rlenferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested locally and for a RelWithDebInfo build the error injection tests are now skipped, and for a Debug build, they run succesfully.

Thanks for fixing!

@PengZheng PengZheng merged commit e7aee12 into master Sep 24, 2023
22 checks passed
@PengZheng PengZheng deleted the hotfix/debug_only_ei_tests branch September 24, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants