Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/coverity fix #709

Closed
wants to merge 4 commits into from
Closed

Feature/coverity fix #709

wants to merge 4 commits into from

Conversation

PengZheng
Copy link
Contributor

This PR fixes a use-after-free in error handing of http_admin and removes ip_utils, whose API is deprecated and no longer used in the Celix project.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ab7b7af) 88.33% compared to head (4df554c) 88.37%.

❗ Current head 4df554c differs from pull request most recent head 780e873. Consider uploading reports for the commit 780e873 to get more accurate results

Files Patch % Lines
...undles/http_admin/http_admin/src/websocket_admin.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   88.33%   88.37%   +0.03%     
==========================================
  Files         215      214       -1     
  Lines       24500    24429      -71     
==========================================
- Hits        21643    21589      -54     
+ Misses       2857     2840      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rlenferink
Copy link
Member

About the ip_utils, I noticed Pepijn is refactoring things on that, see: 01b3af1

Isn’t the potential use case for that the RSA @pnoltes ?

@PengZheng
Copy link
Contributor Author

If ip_utils is still needed, I will revert the remove and fix the newly reported coverity issues.

@pnoltes
Copy link
Contributor

pnoltes commented Jan 1, 2024

About the ip_utils, I noticed Pepijn is refactoring things on that, see: 01b3af1

Isn’t the potential use case for that the RSA @pnoltes ?

Correct I refactored the IP utils and indeed I also kept the IP utils so that they maybe can be used in the RSA implementations.

@PengZheng If the refactored IP util functions in #711 are good enough I think we could keep them for now.

@PengZheng
Copy link
Contributor Author

Let's fix ip_utils in #711.

@PengZheng PengZheng closed this Jan 2, 2024
@PengZheng PengZheng deleted the feature/coverity-fix branch January 2, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants