Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BufferBuilder<u8> with Vec<u8> #13867

Open
jayzhan211 opened this issue Dec 21, 2024 · 1 comment
Open

Replace BufferBuilder<u8> with Vec<u8> #13867

jayzhan211 opened this issue Dec 21, 2024 · 1 comment
Assignees
@poweihuang0817
Labels
enhancement New feature or request

Comments

@jayzhan211
Copy link
Contributor

jayzhan211 commented Dec 21, 2024 •
edited
Loading

Is your feature request related to a problem or challenge?

The functionality we need from BufferBuilder<u8> can be handled by Vec<u8>. Switching to Vec will simplify things, and maybe faster (?

  • ArrowBytesMap
  • ByteGroupValueBuilder
  • regex replace

Describe the solution you'd like

  1. Replace with Vec<u8>
  2. Run the benchmark to see the performance impact

No response

Describe alternatives you've considered

No response

Additional context

Performance should not downgrade.

Suggested by apache/arrow-rs#6909 (comment)
@jayzhan211 jayzhan211 added the enhancement New feature or request label Dec 21, 2024
@poweihuang0817
Copy link

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poweihuang0817 poweihuang0817

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayzhan211 @poweihuang0817