Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-][Alert Instance] Improvement alert plugin instance i18n Informational tips #16815

Open
2 tasks done
sdhzwc opened this issue Nov 18, 2024 · 3 comments
Open
2 tasks done
Labels

Comments

@sdhzwc
Copy link
Contributor

sdhzwc commented Nov 18, 2024

Search before asking

  • I had searched in the DSIP and found no similar DSIP.

Motivation

Further optimization of the issuse #16517
The prompt information is currently hardcoded in the backend, and it needs to be moved to the frontend to avoid interaction with the database.
Backend hardcoding affects internationalization operations

Design Detail

1、Configure all prompt information in the frontend ts and remove the related prompts from the backend
2、Backend set the placeholder field to the retrieved key
3、Front-end adjustment of the retrieval key

Compatibility, Deprecation, and Migration Plan

No response

Test Plan

Test by UT.

Code of Conduct

@sdhzwc sdhzwc added DSIP Waiting for reply Waiting for reply labels Nov 18, 2024
@SbloodyS
Copy link
Member

1、Configure all prompt information in the frontend ts and remove the related prompts from the backend

The current backend creates a frontend alarm plugin in a low-code way, which is to decouple from the frontend. This way is to drive backwards, please don't do this.

@SbloodyS SbloodyS added discussion discussion and removed Waiting for reply Waiting for reply labels Nov 18, 2024
@sdhzwc
Copy link
Contributor Author

sdhzwc commented Nov 18, 2024

The removal here is just expressed by replacing hints with keys
The front-end and back-end judgment methods are all hardcoded, which is not conducive to multilingual expansion
If more languages are introduced later, the enum AlertInputTips will become very bulky

@SbloodyS
Copy link
Member

The removal here is just expressed by replacing hints with keys The front-end and back-end judgment methods are all hardcoded, which is not conducive to multilingual expansion If more languages are introduced later, the enum AlertInputTips will become very bulky

We don't need to consider the support of other languages, English and Chinese are enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants