[Improvement-16802][UI] use relative width for task editor #16769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
requested changes
Nov 5, 2024
3 tasks
SbloodyS
changed the title
SbloodyS
added
improvement
|
zhongjiajie
approved these changes
Nov 16, 2024
| @@ -16,7 +16,7 @@ | |||
| */ | |||
|
|
|||
| .container { | |||
| width: 600px; | |||
| width: 33%; | |||
There was a problem hiding this comment.
NIT, why we use 33% instead of others?
Gallardot
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pull request update task editor style
close #16802
Brief change log
change from fixed width: 600px to 33%, the original one is too narrow to use
Verify this pull request
This pull request is code cleanup without any test coverage.
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md