Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-16850][API] Broadcast to cluster when worker group changed #16860

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Nov 29, 2024

Purpose of the pull request

close #16850

Brief change log

  • Notify master worker group changed once we upsert a worker group.
  • Remove unused param jsonParam

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_broadcastWorkerGroupChanged branch from 51a9712 to 84b34f4 Compare November 29, 2024 11:21
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
45.6% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][API] Broadcast to cluster when worker group changed
1 participant