Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Unintended formatting of front-end sources and xml files #163

Closed
3 tasks done
Pil0tXia opened this issue Jun 16, 2024 · 1 comment · Fixed by #164
Closed
3 tasks done

[Enhancement] Unintended formatting of front-end sources and xml files #163

Pil0tXia opened this issue Jun 16, 2024 · 1 comment · Fixed by #164
Labels
enhancement New feature or request

Comments

@Pil0tXia
Copy link
Member

Pil0tXia commented Jun 16, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

During the process of adjusting code formatting in this pull request, the contributor formatted the entire project code without selecting the "Only format Java file masks" option. This caused the formatting of the front-end project and XML configuration files.

Back-end developers rarely need to deal with JS or TS in their contributions. For front-end developers, the community's front-end developers usually use the .eslintrc file to control the format of npm projects, and it should not be interfered with by XML configurations in IntelliJ IDEA.

Describe the solution you'd like

  • Remove the JS and TS configurations from eventmesh-code-style.xml
  • Standardize XML formatting according to eventmesh-code-style.xml

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Pil0tXia Pil0tXia added the enhancement New feature or request label Jun 16, 2024
@Pil0tXia Pil0tXia changed the title [Enhancement] Enhancement title [Enhancement] Unintended formatting of front-end sources and xml files Jun 16, 2024
@Pil0tXia
Copy link
Member Author

Pil0tXia commented Jun 16, 2024

Whether I follow IDEA's default settings or the existing eventmesh-code-style.xml, the front-end project's code will be formatted. The only solution is to not edit the front-end code in IDEA.

Pil0tXia added a commit that referenced this issue Jun 16, 2024
* Remove unintentionally committed jar package

* format xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant