Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the develop branch instead of dev #36

Closed
qqeasonchen opened this issue Feb 19, 2024 · 5 comments
Closed

Keep the develop branch instead of dev #36

qqeasonchen opened this issue Feb 19, 2024 · 5 comments

Comments

@qqeasonchen
Copy link
Contributor

The name of branch dev is not regular and standard, I suggest a change to develop.

@qqeasonchen
Copy link
Contributor Author

@Pil0tXia @xwm1992

@Pil0tXia
Copy link
Member

Pil0tXia commented Feb 19, 2024

The name of branch dev is not regular and standard

The names 'dev' and 'develop' are both widely used. Typically, we use nouns to name a branch, with 'dev' abbreviation representing the noun 'development,' while 'develop' is a verb. Additionally, 'dev' is shorter than 'develop' while conveying the same meaning.

In the early stages of developing the admin dashboard, active contributors have already agreed upon using the 'dev' branch naming convention and have been developing on their forked repositories with the 'dev' branch. Transitioning to the 'develop' branch may require additional notification.

I personally find the current 'dev' designation suitable, but if you believe that 'develop' is indeed a better name and a change is necessary, I am willing to make the corresponding adjustments accordingly.

image

@qqeasonchen
Copy link
Contributor Author

In my imagination, dev is not very popular, you can find other apache projects as well, just suggestion.

@Pil0tXia
Copy link
Member

Pil0tXia commented Feb 20, 2024

I have reviewed most of the popular Apache projects, and the majority of them do not have a "dev" or "develop" branch 😂; Doris and DolphinScheduler use the "dev" branch, while RocketMQ and Seata use the "develop" branch. This seems to be related to the developers' personal practices.

Anyway, the current "dev" branch will be deleted after the new dashboard's development completes.

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 8, 2024

Completed in #93

@Pil0tXia Pil0tXia closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants