FINERACT-1958: Rework down-payment calculation

[adamsaghy]

Description

2 tests got disabled:
LoanAccountPaymentAllocationWithOverlappingDownPaymentInstallmentTest

1. loanAccountWithEnableDownPaymentAndDisableAutoRepaymentForDownPaymentWithOverlappingInstallmentPaymentAllocationTest()
2. loanAccountWithEnableDownPaymentAndEnableAutoRepaymentForDownPaymentWithOverlappingInstallmentPaymentAllocationTest()

A follow up PR will fix them!

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per https://github.com/apache/fineract/#pull-requests

• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

• Create/update unit or integration tests for verifying the changes made.

• Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

• Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

[ruchiD]

1.Not clear how we are handling overlapping downpayment installments during generate flow.
2.Not clear how we are handling Number of Repayments check during schedule generation.

[adamsaghy]

1.Not clear how we are handling overlapping downpayment installments during generate flow. 2.Not clear how we are handling Number of Repayments check during schedule generation.

1. It does not. Please have a follow up PR to handle them properly
2. The number of repayments does not contain the down-payment installment anymore. We need to only set how many regular installments we want.

[ruchiD]

LGTM