Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] iceberg/iceberg-common module not going through spotless check when compiling IRC binary #5937

Closed
puchengy opened this issue Dec 20, 2024 · 2 comments · Fixed by #6077
Closed

[Improvement] iceberg/iceberg-common module not going through spotless check when compiling IRC binary #5937

puchengy opened this issue Dec 20, 2024 · 2 comments · Fixed by #6077
Assignees
@cool9850311
Labels
0.8.0 Release v0.8.0 good first issue Good for newcomers improvement Improvements on everything

Comments

@puchengy
Copy link
Contributor

What would you like to be improved?

iceberg/iceberg-common module is not having spotless check at least when compiling IRC binary

How should we improve?

The compiling process should fail with error message to fix the module code style
@puchengy puchengy added the improvement Improvements on everything label Dec 20, 2024
@jerryshao jerryshao added good first issue Good for newcomers 0.8.0 Release v0.8.0 labels Dec 30, 2024
@cool9850311
Copy link
Contributor

@puchengy
As I know spotless check is assigned to every gradle.kts by main gradle, and it will do spotless check on build (not compile)for all packages.

So could you explain the "Compiling IRC Binary" part? Thanks.

@puchengy
Copy link
Contributor Author

puchengy commented Jan 2, 2025

@cool9850311 sure, when running ./gradlew compileIcebergRESTServer -x test, it seems not performing spotless check for iceberg-common module.

cool9850311 added a commit to cool9850311/gravitino that referenced this issue Jan 3, 2025
@cool9850311
[apache#5937] Add spotlessCheck to iceberg-common module on compileIc…
76f9439 
…ebergRESTServer

What changes were proposed in this pull request?
Add spotlessCheck to iceberg-common module on compileIcebergRESTServer

Why are the changes needed?
Fix: apache#5937

Does this PR introduce any user-facing change?
no

How was this patch tested?
Break style by adding spaces to any java file in  iceberg-common module, and test it by running ./gradlew compileIcebergRESTServer -x test
@cool9850311 cool9850311 mentioned this issue Jan 3, 2025
Closed
cool9850311 added a commit to cool9850311/gravitino that referenced this issue Jan 3, 2025
@cool9850311
[apache#5937] Add spotlessCheck to iceberg-common module on compileIc…
78cef3b 
…ebergRESTServer

What changes were proposed in this pull request?
Add spotlessCheck to iceberg-common module on compileIcebergRESTServer

Why are the changes needed?
Fix: apache#5937

Does this PR introduce any user-facing change?
no

How was this patch tested?
Break style by adding spaces to any java file in  iceberg-common module, and test it by running ./gradlew compileIcebergRESTServer -x test
@cool9850311 cool9850311 mentioned this issue Jan 3, 2025
Merged
cool9850311 added a commit to cool9850311/gravitino that referenced this issue Jan 4, 2025
@cool9850311
[apache#5937]feat(build): enhance spotless integration in Gradle buil…
b5cf23d 
…d script

### What changes were proposed in this pull request?
Added configuration to ensure that subprojects using the 'com.diffplug.spotless' plugin are included in the 'spotlessCheck' task dependencies.

###Why are the changes needed?
Fix: apache#5937

###Does this PR introduce any user-facing change?
no

###How was this patch tested?
Break style by adding spaces to any java file in iceberg-common module, and test it by running ./gradlew compileIcebergRESTServer -x test
check dependence trees by running ./gradlew compileIcebergRESTServer taskTree
jerryshao pushed a commit that referenced this issue Jan 6, 2025
@cool9850311
[#5937]feat(build): enhance spotless integration in Gradle build scri…
a25f758 
…pt (#6077)

### What changes were proposed in this pull request?
Added configuration to ensure that subprojects using the
'com.diffplug.spotless' plugin are included in the 'spotlessCheck' task
dependencies.

### Why are the changes needed?
Fix: #5937

### Does this PR introduce any user-facing change?
no

### How was this patch tested?
Break style by adding spaces to any java file in iceberg-common module,
and test it by running ./gradlew compileIcebergRESTServer -x test
check dependence trees by running ./gradlew compileIcebergRESTServer
taskTree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cool9850311 cool9850311

Labels
0.8.0 Release v0.8.0 good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
3 participants
@jerryshao @puchengy @cool9850311