Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 21 (new LTS) Support #10954

Closed
magicprinc opened this issue Sep 22, 2023 · 9 comments
Closed

JDK 21 (new LTS) Support #10954

magicprinc opened this issue Sep 22, 2023 · 9 comments

Comments

@magicprinc
Copy link

magicprinc commented Sep 22, 2023

Please add JDK 21 support! 🙏


The first obstacle:
ClassNotFoundException: jdk.internal.misc.SharedSecrets
in
org.apache.ignite.internal.util.GridUnsafe#javaNioAccessObject

Java 21 new class name: jdk.internal.access.SharedSecrets

@magicprinc
Copy link
Author

magicprinc commented Sep 22, 2023

My JVM ultra options pack

-XX:+UseParallelGC
-XX:+HeapDumpOnOutOfMemoryError
-XX:+UseCompressedOops
-XX:-OmitStackTraceInFastThrow
-Djava.net.preferIPv4Stack=true
-Dfile.encoding=UTF-8
-XX:+DoEscapeAnalysis
-XX:CompileCommand=inline,java/lang/String.charAt
--add-opens=java.base/jdk.internal.misc=ALL-UNNAMED
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED
--add-opens=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED
--add-opens=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
--add-opens=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED
--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED
--add-opens=java.base/java.io=ALL-UNNAMED
--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.lang.invoke=ALL-UNNAMED
--add-opens=java.base/java.math=ALL-UNNAMED
--add-opens=java.sql/java.sql=ALL-UNNAMED
--add-opens=java.base/java.net=ALL-UNNAMED

@ivandasch
Copy link
Contributor

Could you please check with these set of 'add-opens'?

--add-opens=java.base/jdk.internal.misc=ALL-UNNAMED 
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED 
--add-opens=java.management/com.sun.jmx.mbeanserver=ALL-UNNAMED 
--add-opens=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED
--add-opens=java.base/sun.reflect.generics.reflectiveObjects=ALL-UNNAMED 
--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED 
--add-opens=java.base/java.io=ALL-UNNAMED 
--add-opens=java.base/java.nio=ALL-UNNAMED 
--add-opens=java.base/java.util=ALL-UNNAMED 
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED 
--add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED 
--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED 
--add-opens=java.base/java.lang=ALL-UNNAMED 
--add-opens=java.base/java.lang.invoke=ALL-UNNAMED 
--add-opens=java.base/java.math=ALL-UNNAMED 
--add-opens=java.sql/java.sql=ALL-UNNAMED 
--add-opens=java.base/java.lang.reflect=ALL-UNNAMED 
--add-opens=java.base/java.time=ALL-UNNAMED 
--add-opens=java.base/java.text=ALL-UNNAMED 
--add-opens=java.management/sun.management=ALL-UNNAMED 
--add-opens java.desktop/java.awt.font=ALL-UNNAMED

@ivandasch
Copy link
Contributor

If this set is applied you should not fall back to SharedSecrets

@ivandasch
Copy link
Contributor

Will be fixed in #10969

@ivandasch
Copy link
Contributor

Fixed in #10969

@apupier
Copy link

apupier commented Oct 18, 2023

Do you have information when a release with the Java 21 support will be available?
Are there plans to backport Java 21 support to 2.x?
EDIT: realizing that this repo is for 2.x and for 3.x, i tis in another one https://github.com/apache/ignite-3

@apupier
Copy link

apupier commented Oct 23, 2023

release proposal on dev mailing list: https://lists.apache.org/thread/3nqy8chd0xyopvvhk6o19g2z3p10smzb

@magicprinc
Copy link
Author

Any news?

There were plans to release in November... 🙏😥

@ptupitsyn
Copy link
Contributor

@magicprinc see the link above, we are working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants