-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: solve spring and tcc dependency #4644
optimize: solve spring and tcc dependency #4644
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4644 +/- ##
=============================================
+ Coverage 48.62% 48.79% +0.16%
- Complexity 4052 4055 +3
=============================================
Files 732 740 +8
Lines 25773 25805 +32
Branches 3173 3178 +5
=============================================
+ Hits 12532 12591 +59
- Misses 11909 11913 +4
+ Partials 1332 1301 -31
|
spring/src/main/java/io/seata/spring/autoproxy/DefaultTransactionAutoProxy.java
Outdated
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
Show resolved
Hide resolved
spring/src/main/java/io/seata/spring/autoproxy/TransactionAutoProxy.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nto feature_spring_tcc_dependency
…nto feature_spring_tcc_dependency
…ncy_manual_api # Conflicts: # common/src/main/java/io/seata/common/Constants.java # common/src/main/java/io/seata/common/DefaultValues.java # spring/src/main/java/io/seata/spring/fence/CommonFenceHandler.java # spring/src/main/java/io/seata/spring/fence/store/CommonFenceStore.java # spring/src/main/java/io/seata/spring/fence/store/db/CommonFenceStoreDataBaseDAO.java # spring/src/main/java/io/seata/spring/fence/store/db/sql/CommonFenceStoreSqls.java # spring/src/main/java/io/seata/spring/interceptor/ActionInterceptorHandler.java # spring/src/main/java/io/seata/spring/interceptor/TxAnnotationProcessor.java # spring/src/main/java/io/seata/spring/interceptor/TxBeanParserUtils.java # spring/src/main/java/io/seata/spring/remoting/RemotingDesc.java # spring/src/main/java/io/seata/spring/remoting/parser/DefaultRemotingParser.java # spring/src/main/java/io/seata/spring/remoting/parser/DubboRemotingParser.java # tcc/pom.xml # tcc/src/main/java/io/seata/rm/tcc/interceptor/TccActionInterceptor.java # tcc/src/main/java/io/seata/rm/tcc/remoting/parser/LocalTCCRemotingParser.java
…nto feature_spring_tcc_dependency
ruishansun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ruishansun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Ⅰ. Describe what this PR did
This PR solve the dependency issue between seata-spring and seata-tcc. the seata-tcc should depend on seata-spring, but they are opposite now.
Make abstract transaction auto proxy, it will be implements by tcc with SPI. It's for saga anatation mode reservation.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews