Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: solve spring and tcc dependency #4644

Closed
wants to merge 34 commits into from
Closed

optimize: solve spring and tcc dependency #4644

wants to merge 34 commits into from

Conversation

sunrui1225
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

This PR solve the dependency issue between seata-spring and seata-tcc. the seata-tcc should depend on seata-spring, but they are opposite now.
Make abstract transaction auto proxy, it will be implements by tcc with SPI. It's for saga anatation mode reservation.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #4644 (df24269) into develop (caeb231) will increase coverage by 0.16%.
The diff coverage is 13.86%.

❗ Current head df24269 differs from pull request most recent head a4d3eb8. Consider uploading reports for the commit a4d3eb8 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4644      +/-   ##
=============================================
+ Coverage      48.62%   48.79%   +0.16%     
- Complexity      4052     4055       +3     
=============================================
  Files            732      740       +8     
  Lines          25773    25805      +32     
  Branches        3173     3178       +5     
=============================================
+ Hits           12532    12591      +59     
- Misses         11909    11913       +4     
+ Partials        1332     1301      -31     
Impacted Files Coverage Δ
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <ø> (ø)
...n/src/main/java/io/seata/common/DefaultValues.java 0.00% <ø> (ø)
...configure/SeataClientEnvironmentPostProcessor.java 0.00% <0.00%> (ø)
.../autoconfigure/SeataTCCFenceAutoConfiguration.java 0.00% <0.00%> (ø)
...ava/io/seata/rm/tcc/api/BusinessActionContext.java 0.00% <0.00%> (ø)
...io/seata/rm/tcc/api/BusinessActionContextUtil.java 0.00% <0.00%> (ø)
...g/src/main/java/io/seata/rm/tcc/api/ParamType.java 0.00% <ø> (ø)
...ta/spring/annotation/GlobalTransactionScanner.java 9.45% <0.00%> (-21.21%) ⬇️
.../spring/autoproxy/DefaultTransactionAutoProxy.java 0.00% <0.00%> (ø)
...ata/spring/autoproxy/IsTransactionProxyResult.java 0.00% <0.00%> (ø)
... and 109 more

@sunrui1225 sunrui1225 changed the title solve spring and tcc dependency issue optimized: solve spring and tcc dependency issue May 31, 2022
@sunrui1225 sunrui1225 changed the title optimized: solve spring and tcc dependency issue optimized: solve spring and tcc dependency May 31, 2022
@funky-eyes funky-eyes added type: optimize first-time contributor first-time contributor module/spring spring module module/tcc tcc module labels Jul 4, 2022
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 changed the title optimized: solve spring and tcc dependency optimize: solve spring and tcc dependency Jul 21, 2022
wangliang181230 and others added 16 commits July 26, 2022 17:39
…ncy_manual_api

# Conflicts:
#	common/src/main/java/io/seata/common/Constants.java
#	common/src/main/java/io/seata/common/DefaultValues.java
#	spring/src/main/java/io/seata/spring/fence/CommonFenceHandler.java
#	spring/src/main/java/io/seata/spring/fence/store/CommonFenceStore.java
#	spring/src/main/java/io/seata/spring/fence/store/db/CommonFenceStoreDataBaseDAO.java
#	spring/src/main/java/io/seata/spring/fence/store/db/sql/CommonFenceStoreSqls.java
#	spring/src/main/java/io/seata/spring/interceptor/ActionInterceptorHandler.java
#	spring/src/main/java/io/seata/spring/interceptor/TxAnnotationProcessor.java
#	spring/src/main/java/io/seata/spring/interceptor/TxBeanParserUtils.java
#	spring/src/main/java/io/seata/spring/remoting/RemotingDesc.java
#	spring/src/main/java/io/seata/spring/remoting/parser/DefaultRemotingParser.java
#	spring/src/main/java/io/seata/spring/remoting/parser/DubboRemotingParser.java
#	tcc/pom.xml
#	tcc/src/main/java/io/seata/rm/tcc/interceptor/TccActionInterceptor.java
#	tcc/src/main/java/io/seata/rm/tcc/remoting/parser/LocalTCCRemotingParser.java
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ wangliang181230
✅ a364176773
✅ sunrui1225
❌ ruishansun


ruishansun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 4 committers have signed the CLA.

❌ sunrui1225
❌ wangliang181230
❌ a364176773
❌ ruishansun


ruishansun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sunrui1225 sunrui1225 closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/spring spring module module/tcc tcc module type: optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants