optimize: add the default console and security config on application.examle.yml #6732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Aug 6, 2024
There was a problem hiding this comment.
https://github.com/apache/incubator-seata/blob/2.x/server/src/main/resources/application.raft.example.yml
应该也要进行补充
It should also be supplemented.
|
changes 下的2.x.md 中英两个版本都要登记下pr信息和作者信息。 |
okay, all done. |
funky-eyes
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6732 +/- ##
============================================
- Coverage 50.84% 50.76% -0.08%
+ Complexity 5914 5899 -15
============================================
Files 1058 1058
Lines 36717 36717
Branches 4364 4364
============================================
- Hits 18669 18641 -28
- Misses 16161 16189 +28
Partials 1887 1887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add the default console and security config on application.examle.yml(#6725)
Ⅱ. Does this pull request fix one issue?
fixes #6725
Ⅲ. Why don't you add test cases (unit test/integration test)?
it donnot need
Ⅳ. Describe how to verify it
unzip the seata-server.zip, and rename
application.ymltoapplication.yml.bak,application.example.ymltoapplication.ymlonseata-server. then execute theseata-server.shshell script, check whether startup successfully.Ⅴ. Special notes for reviews