Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: upgrade tomcat-embed-core to 9.0.90 #6741

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Aug 11, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

upgrade tomcat-embed-core to 9.0.90

Ⅱ. Does this pull request fix one issue?

https://github.com/apache/incubator-seata/security/dependabot/153
https://github.com/apache/incubator-seata/security/dependabot/154
https://github.com/apache/incubator-seata/security/dependabot/135
https://github.com/apache/incubator-seata/security/dependabot/136

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.88%. Comparing base (51ff4fb) to head (ec48212).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6741      +/-   ##
============================================
+ Coverage     50.87%   50.88%   +0.01%     
- Complexity     5914     5916       +2     
============================================
  Files          1058     1058              
  Lines         36772    36772              
  Branches       4366     4368       +2     
============================================
+ Hits          18708    18712       +4     
+ Misses        16174    16172       -2     
+ Partials       1890     1888       -2     

see 2 files with indirect coverage changes

@slievrly slievrly added this to the 2.2.0 milestone Aug 11, 2024
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 880ef0f into apache:2.x Aug 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants