Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase spring autoconfigure module unit test coverage #6750

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6199

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.29%. Comparing base (ff1fa8f) to head (d29dd80).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6750      +/-   ##
============================================
+ Coverage     50.72%   52.29%   +1.57%     
- Complexity     5961     6297     +336     
============================================
  Files          1063     1063              
  Lines         37153    37153              
  Branches       4406     4406              
============================================
+ Hits          18844    19431     +587     
+ Misses        16386    15807     -579     
+ Partials       1923     1915       -8     

see 52 files with indirect coverage changes

Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi changed the title Test: increase spring autoconfigure module unit test coverage test: increase spring autoconfigure module unit test coverage Aug 18, 2024
@l81893521 l81893521 merged commit 79a6744 into apache:2.x Aug 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the spring autoconfigure module unit test coverage
3 participants