Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Go 1.7 is no longer suitable for building CI #33

Open
de-nordic opened this issue Oct 4, 2019 · 7 comments
Open

Documentation: Go 1.7 is no longer suitable for building CI #33

de-nordic opened this issue Oct 4, 2019 · 7 comments

Comments

@de-nordic
Copy link
Contributor

Regarding "Command line tool" paragraph;

Due to changes applied with
apache/mynewt-newt@6a51e35, which is usage of ProcessState.ExitCode(), in newt/util.go, the minimal requirement for go compiler is now version 1.11.1.

@utzig
Copy link
Member

utzig commented Oct 4, 2019

I think it already required a minimum version of 1.12 because of this: apache/mynewt-newt@53f9e0c

@utzig
Copy link
Member

utzig commented Oct 4, 2019

@de-nordic Ah, you can probably disregard my comment, mynewt-mcumgr-cli depends only on newt/util so the version you mentioned seems correct.

@de-nordic
Copy link
Contributor Author

Might be, I have built go from the top of master at that point (27fc32ff01) for the purpose of building the tool, so I have been far beyond 1.11.1 anyway during build; I have tracked missing feature to be included within go 11.1.1, since the version mentioned.

@baw-serafin
Copy link

baw-serafin commented Nov 16, 2020

Seems at least 1.12 is needed becasue of os.ProcessState getting:

src/mynewt.apache.org/newt/util/util.go:498:10: state.ExitCode undefined (type *os.ProcessState has no field or method ExitCode)

With 1.11.6

@chrta
Copy link

chrta commented Mar 22, 2021

The README.md still mentions:

The command line tool requires Go 1.7 or later.

Is this the only place where this information is out-of-date?

@alokprinc
Copy link
Contributor

I want to work on this issue

@alokprinc
Copy link
Contributor

i have made changes merge if you are satisfied and tell me if any I can help you with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants