From d4f8dca5eb35a26cdb79b8526b9744088ce04756 Mon Sep 17 00:00:00 2001
From: deshanxiao <deshanxiao@microsoft.com>
Date: Tue, 10 Oct 2023 20:03:43 -0700
Subject: [PATCH] ORC-1518: Remove findbugs folders

### What changes were proposed in this pull request?
This PR is aimed to remove findbugs folders since findbugs has been removed in [ORC-1269](https://issues.apache.org/jira/browse/ORC-1269).

### Why are the changes needed?
Remove redundant files.

### How was this patch tested?
N/A

Closes #1635 from deshanxiao/orc-1518.

Authored-by: deshanxiao <deshanxiao@microsoft.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
---
 java/bench/core/src/findbugs/exclude.xml  |  25 ------
 java/bench/hive/src/findbugs/exclude.xml  |  25 ------
 java/bench/spark/src/findbugs/exclude.xml |  25 ------
 java/core/src/findbugs/exclude.xml        | 104 ----------------------
 java/examples/src/findbugs/exclude.xml    |  19 ----
 java/mapreduce/src/findbugs/exclude.xml   |  20 -----
 java/shims/src/findbugs/exclude.xml       |  19 ----
 java/tools/src/findbugs/exclude.xml       |  33 -------
 8 files changed, 270 deletions(-)
 delete mode 100644 java/bench/core/src/findbugs/exclude.xml
 delete mode 100644 java/bench/hive/src/findbugs/exclude.xml
 delete mode 100644 java/bench/spark/src/findbugs/exclude.xml
 delete mode 100644 java/core/src/findbugs/exclude.xml
 delete mode 100644 java/examples/src/findbugs/exclude.xml
 delete mode 100644 java/mapreduce/src/findbugs/exclude.xml
 delete mode 100644 java/shims/src/findbugs/exclude.xml
 delete mode 100644 java/tools/src/findbugs/exclude.xml

diff --git a/java/bench/core/src/findbugs/exclude.xml b/java/bench/core/src/findbugs/exclude.xml
deleted file mode 100644
index e9fe859942..0000000000
--- a/java/bench/core/src/findbugs/exclude.xml
+++ /dev/null
@@ -1,25 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
--->
-<FindBugsFilter>
-  <Match>
-    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
-  </Match>
-  <Match>
-    <Class name="~org\.openjdk\.jmh\.infra\.generated.*"/>
-  </Match>
-  <Match>
-    <Class name="~org\.apache\.orc\.bench\..*\.generated.*"/>
-  </Match>
-</FindBugsFilter>
diff --git a/java/bench/hive/src/findbugs/exclude.xml b/java/bench/hive/src/findbugs/exclude.xml
deleted file mode 100644
index 6fec73cb05..0000000000
--- a/java/bench/hive/src/findbugs/exclude.xml
+++ /dev/null
@@ -1,25 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
--->
-<FindBugsFilter>
-  <Match>
-    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2,MS_EXPOSE_REP,DM_EXIT"/>
-  </Match>
-  <Match>
-    <Class name="~org\.openjdk\.jmh\.infra\.generated.*"/>
-  </Match>
-  <Match>
-    <Class name="~org\.apache\.orc\.bench.*\.generated.*"/>
-  </Match>
-</FindBugsFilter>
diff --git a/java/bench/spark/src/findbugs/exclude.xml b/java/bench/spark/src/findbugs/exclude.xml
deleted file mode 100644
index 64f2e31c63..0000000000
--- a/java/bench/spark/src/findbugs/exclude.xml
+++ /dev/null
@@ -1,25 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
--->
-<FindBugsFilter>
-  <Match>
-    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2,MS_EXPOSE_REP"/>
-  </Match>
-  <Match>
-    <Class name="~org\.openjdk\.jmh\.infra\.generated.*"/>
-  </Match>
-  <Match>
-    <Class name="~org\.apache\.orc\.bench.*\.generated.*"/>
-  </Match>
-</FindBugsFilter>
diff --git a/java/core/src/findbugs/exclude.xml b/java/core/src/findbugs/exclude.xml
deleted file mode 100644
index ea94a421c9..0000000000
--- a/java/core/src/findbugs/exclude.xml
+++ /dev/null
@@ -1,104 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
--->
-<FindBugsFilter>
-  <Match>
-    <Class name="~org\.apache\.orc\.OrcProto.*"/>
-  </Match>
-  <Match>
-    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
-  </Match>
-  <Match>
-    <Bug pattern="CN_IDIOM_NO_SUPER_CALL"/>
-    <Class name="org.apache.orc.TypeDescription"/>
-  </Match>
-  <Match>
-    <Bug pattern="SF_SWITCH_FALLTHROUGH,SF_SWITCH_NO_DEFAULT"/>
-    <Class name="org.apache.orc.util.Murmur3"/>
-  </Match>
-  <Match>
-    <Bug pattern="MS_PKGPROTECT"/>
-    <Class name="org.apache.orc.impl.RecordReaderImpl$SargApplier"/>
-  </Match>
-  <Match>
-    <Bug pattern="CNT_ROUGH_CONSTANT_VALUE,IM_BAD_CHECK_FOR_ODD"/>
-    <Class name="org.apache.orc.TestVectorOrcFile"/>
-  </Match>
-  <Match>
-    <Bug pattern="RR_NOT_CHECKED"/>
-    <Class name="org.apache.orc.impl.TestInStream"/>
-    <Method name="testCorruptStream"/>
-  </Match>
-  <!-- Java's try with resources causes a false positive.
-       See https://github.com/SERG-Delft/jpacman/pull/27 . -->
-  <Match>
-    <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
-    <Class name="org.apache.orc.OrcUtils"/>
-    <Method name="getOrcVersion"/>
-  </Match>
-  <Match>
-    <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-    <Class name="org.apache.orc.impl.OrcAcidUtils"/>
-    <Method name="getLastFlushLength"/>
-  </Match>
-  <Match>
-    <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-    <Class name="~org\.apache\.orc.*\.Test.*"/>
-  </Match>
-  <Match>
-    <Bug pattern="EQ_UNUSUAL"/>
-    <Class name="org.apache.orc.TypeDescription"/>
-    <Method name="equals" />
-  </Match>
-  <Match>
-    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
-    <Class name="org.apache.orc.impl.StreamName"/>
-    <Method name="compareTo" />
-  </Match>
-  <Match>
-    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
-    <Class name="org.apache.orc.impl.reader.ReaderEncryptionKey"/>
-    <Method name="compareTo" />
-  </Match>
-  <Match>
-    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
-    <Class name="org.apache.orc.impl.reader.ReaderEncryptionVariant"/>
-    <Method name="compareTo" />
-  </Match>
-  <Match>
-    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
-    <Class name="org.apache.orc.impl.MaskDescriptionImpl"/>
-    <Method name="compareTo" />
-  </Match>
-  <Match>
-    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
-    <Class name="org.apache.orc.impl.TreeReaderFactory$TreeReader"/>
-    <Method name="&lt;init&gt;" />
-  </Match>
-  <Match>
-    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
-    <Class name="org.apache.orc.impl.writer.WriterEncryptionKey"/>
-    <Method name="compareTo" />
-  </Match>
-  <Match>
-    <Bug pattern="NP_NULL_ON_SOME_PATH"/>
-    <Class name="org.apache.orc.impl.writer.WriterEncryptionVariant"/>
-    <Method name="compareTo" />
-  </Match>
-  <Match>
-    <Bug pattern="NP_NULL_PARAM_DEREF"/>
-    <Class name="org.apache.orc.impl.reader.StripePlanner"/>
-    <Method name="planPartialDataReading" />
-  </Match>
-</FindBugsFilter>
diff --git a/java/examples/src/findbugs/exclude.xml b/java/examples/src/findbugs/exclude.xml
deleted file mode 100644
index fd215c0e8f..0000000000
--- a/java/examples/src/findbugs/exclude.xml
+++ /dev/null
@@ -1,19 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
--->
-<FindBugsFilter>
-  <Match>
-    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2,DM_EXIT"/>
-  </Match>
-</FindBugsFilter>
diff --git a/java/mapreduce/src/findbugs/exclude.xml b/java/mapreduce/src/findbugs/exclude.xml
deleted file mode 100644
index 56b707e830..0000000000
--- a/java/mapreduce/src/findbugs/exclude.xml
+++ /dev/null
@@ -1,20 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
--->
-<FindBugsFilter>
-  <Match>
-    <Bug pattern="CNT_ROUGH_CONSTANT_VALUE"/>
-    <Class name="org.apache.orc.mapred.TestOrcFileEvolution"/>
-  </Match>
-</FindBugsFilter>
diff --git a/java/shims/src/findbugs/exclude.xml b/java/shims/src/findbugs/exclude.xml
deleted file mode 100644
index d6441f15d3..0000000000
--- a/java/shims/src/findbugs/exclude.xml
+++ /dev/null
@@ -1,19 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
--->
-<FindBugsFilter>
-  <Match>
-    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
-  </Match>
-</FindBugsFilter>
diff --git a/java/tools/src/findbugs/exclude.xml b/java/tools/src/findbugs/exclude.xml
deleted file mode 100644
index 555068bc93..0000000000
--- a/java/tools/src/findbugs/exclude.xml
+++ /dev/null
@@ -1,33 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
--->
-<FindBugsFilter>
-  <Match>
-    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2,DM_EXIT"/>
-  </Match>
-  <!-- Java's try with resources causes a false positive.
-       See https://github.com/SERG-Delft/jpacman/pull/27 . -->
-  <Match>
-    <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE,RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
-  </Match>
-  <Match>
-    <Bug pattern="REC_CATCH_EXCEPTION"/>
-    <Class name="org.apache.orc.tools.ScanData"/>
-    <Method name="main"/>
-  </Match>
-  <Match>
-    <Bug pattern="DM_DEFAULT_ENCODING" />
-    <Class name="org.apache.orc.tools.PrintData" />
-  </Match>
-</FindBugsFilter>