Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update genjavadoc #1187

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Update genjavadoc #1187

merged 1 commit into from
Mar 12, 2024

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Mar 12, 2024

While this project didn't exhibit the issue with genjavadoc now, since its using Scala 2.13.13 we should update to the latest version of genjavadoc so we don't get any surprises in the future.

Note that this is also safe to backport to 1.0.x because the only notable changes between genjavadoc 0.18 and 0.19 is the fix for Scala 2.13.13

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that it's good to update on main.

Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdedetrich mdedetrich merged commit 1b63e60 into apache:main Mar 12, 2024
18 checks passed
@mdedetrich mdedetrich deleted the update-genjavadoc branch March 12, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants