[DISCUSS] Change the NettyHashTimerTimeoutManager to throw PlcTimeoutExceptions?

[chrisdutz]

Hi all,

so I just noticed, that the NettyHashTimerTimeoutManager throws "TimeoutExceptions" if an operation takes too long.
Unfortunately this is outside the "PlcException" or "PlcRuntimeException" hierarchy and therefore falls through many PlcExcpeiton catch blocks ... I'd like to change this to throw exceptions that are children of PlcRuntimeException.

What do you think?

Chris

[sruehl]

yes, please

[sruehl]

and while at it we should search (regex) if there are any non PlcExceptions are thrown

[chrisdutz]

I guess most plc connection cache issues can be tracked back to that general problem ...

[splatch]

The TimeoutException is a common java type for reporting timeouts, I am not sure if CompletableFuture have any special handling for it, but other places can actually rely on it. Personally I don't mind changing it to throw PlcTimeoutException, as long as it is consistent and does not confuse users I'm all for it.