-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces com.ecwid.consul:consul-api
with io.vertx:vertx-consul-client
in shardingsphere-plugin-mode-cluster-repository-consul
#33
Labels
Comments
33 tasks
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
|
|
linghengqian
changed the title
Replaces
Replaces Mar 27, 2024
com.ecwid.consul:consul-api
with io.vertx:vertx-consul-client
in shardingsphere-cluster-mode-repository-consul
com.ecwid.consul:consul-api
with io.vertx:vertx-consul-client
in shardingsphere-plugin-mode-cluster-repository-consul
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
For English only, other languages will not be accepted.
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will close it.
Please answer these questions before submitting your issue. Thanks!
Is your feature request related to a problem?
Describe the feature you would like.
com.ecwid.consul:consul-api
has not released a new version for 4 years, which has led to issues like Some API is deprecated in version 1.15.x! Ecwid/consul-api#246 and was released in Consul 1.17 .x will be completely unavailable. Issues like Consider replacing https://github.com/Ecwid/consul-api with Interface Clients spring-cloud/spring-cloud-consul#475 are actively being moved away fromcom.ecwid.consul:consul-api
.Issues like Add client support for Watches Ecwid/consul-api#19 expose that
com.ecwid.consul:consul-api
does not encapsulate the watches API at all, refer to https://developer.hashicorp.com/consul/docs/v1.17.x/dynamic-app-config/watches . This resulted inshardingsphere-plugin-mode-cluster-repository-consul
even operating theindex
manually, which caused a lot of confusion in further maintenance.According to an investigation at Add GraalVM Reachability Metadata and corresponding nativeTest for Consul integration shardingsphere#29588 , the Consul integration is currently unavailable, again requiring further investigation.
This issue target is handling two subtasks.
Replaces
com.ecwid.consul:consul-api
withcom.orbitz.consul:consul-client
.com.orbitz.consul:consul-client
has been archived, its last release is later thancom.ecwid.consul:consul-api
. It also provides an encapsulation of thewatches
interface, simplifying the use ofConsul Index
handling, which helps align the operations of existing Zookeeper integration implementations in ShardingSphere.org.kiwiproject:consul-client
, there is nothing that can be done about ShardingSphere considering that Update minimum Java version to 11 kiwiproject/consul-client#39 improves the JDK compiled version to JDK11.Replaces
com.orbitz.consul:consul-client
withio.vertx:vertx-consul-client
.io.vertx:vertx-consul-client
is the only Java Client for Consul currently being maintained. I don't think we should actively encapsulate HttpClient, this kind of thing should be done by a third party.The text was updated successfully, but these errors were encountered: