Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: finding pipes by guaranteed and documented order of operations #22

Open
osher opened this issue Nov 21, 2016 · 1 comment

Comments

@osher
Copy link

osher commented Nov 21, 2016

the current way forces us to "rename" a pipe in order to pass fittings-config to it.
e.g.

bagpipes:
  my-customized-fitting:
    name:   my-fitting
    custom: setting1
    tuned:  value
  
  my-pipe:
    - my-customized-fitting

Why couldn't it be just:

bagpipes:
  my-fitting:
    custom: setting
    tuned:  value

  my-pipe:
    - my-fitting
@osher
Copy link
Author

osher commented Nov 21, 2016

Edited: fixed wordings...

To do this we need to guarantee order of operations in pipe-finding:

  • named pipe exists in memory?
    • yes - use it.
    • no:
      • load pipe factory (according to configured user-fitting + system-fitting, throws not-found error)
      • if fittingDef has no name - use key as name
      • invoke pipe factory with fittingDef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant