[VOTE] Release Apollo version 2.0.0-RC1

[nobodyiam]

Hi All,

@apolloconfig/pmc @apolloconfig/committers This is a call for vote to release Apollo version 2.0.0-RC1.

Release Note:

• https://github.com/apolloconfig/apollo/releases/tag/v2.0.0-RC1

Release Candidate:

• https://github.com/apolloconfig/apollo/releases/download/v2.0.0-RC1/apollo-configservice-2.0.0-RC1-github.zip
• https://github.com/apolloconfig/apollo/releases/download/v2.0.0-RC1/apollo-adminservice-2.0.0-RC1-github.zip
• https://github.com/apolloconfig/apollo/releases/download/v2.0.0-RC1/apollo-portal-2.0.0-RC1-github.zip
• sha1 checksums
  • e970193cc62b5cf1a85c0894c0710f12c22ea5de apollo-configservice-2.0.0-RC1-github.zip
  • 5507bbc8c38a9bb9f1b1bc382b809cf86a791d19 apollo-adminservice-2.0.0-RC1-github.zip
  • 7f5620ed118fe4581a95a1cd1bc8201963a57b8e apollo-portal-2.0.0-RC1-github.zip

Maven 2 staging repository:

• https://oss.sonatype.org/service/local/repositories/comctrip-1032/content/com/ctrip/framework/apollo/

<repositories>
    <repository>
        <id>sonatype-nexus-release</id>
        <url>https://oss.sonatype.org/service/local/repositories/comctrip-1032/content</url>
        <releases>
            <enabled>true</enabled>
        </releases>
        <snapshots>
            <enabled>true</enabled>
        </snapshots>
    </repository>
</repositories>

Release Tag :

• https://github.com/apolloconfig/apollo/releases/tag/v2.0.0-RC1

Release CommitID :

• a882f3e

Guide to build the release from source:

• https://www.apolloconfig.com/#/zh/deployment/distributed-deployment-guide?id=_2212-%e9%80%9a%e8%bf%87%e6%ba%90%e7%a0%81%e6%9e%84%e5%bb%ba

Voting will start now (2022/4/07) and will remain open for at least 72 hours, Request all PMC members and committers to give their vote.
[ ] +1 Release this package.
[ ] +0 No opinion.
[ ] -1 Do not release this package because....

[JaredTan95]

+1 Release this package.

[lepdou]

+1 Release this package.

I have verified upgrading from 1.9.2 to 2.0.0.

---

One problem is mysql connection url should add serverTimezone=Asia/Shanghai param in build.sh. Otherwise errors will throws when application access mysql.

Caused by: org.hibernate.exception.GenericJDBCException: could not execute query
	at org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:42)
	at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:113)
	at org.hibernate.loader.Loader.doList(Loader.java:2871)
	at org.hibernate.loader.Loader.doList(Loader.java:2850)
	at org.hibernate.loader.Loader.listIgnoreQueryCache(Loader.java:2682)
	at org.hibernate.loader.Loader.list(Loader.java:2677)
	at org.hibernate.loader.hql.QueryLoader.list(QueryLoader.java:540)
	at org.hibernate.hql.internal.ast.QueryTranslatorImpl.list(QueryTranslatorImpl.java:400)
	at org.hibernate.engine.query.spi.HQLQueryPlan.performList(HQLQueryPlan.java:219)
	at org.hibernate.internal.SessionImpl.list(SessionImpl.java:1459)
	at org.hibernate.query.internal.AbstractProducedQuery.doList(AbstractProducedQuery.java:1649)
	at org.hibernate.query.internal.AbstractProducedQuery.list(AbstractProducedQuery.java:1617)
	at org.hibernate.query.Query.getResultList(Query.java:165)
	at org.hibernate.query.criteria.internal.compile.CriteriaQueryTypeQueryAdapter.getResultList(CriteriaQueryTypeQueryAdapter.java:76)
	at org.springframework.data.jpa.repository.query.JpaQueryExecution$CollectionExecution.doExecute(JpaQueryExecution.java:128)
	at org.springframework.data.jpa.repository.query.JpaQueryExecution.execute(JpaQueryExecution.java:90)
	at org.springframework.data.jpa.repository.query.AbstractJpaQuery.doExecute(AbstractJpaQuery.java:155)
	at org.springframework.data.jpa.repository.query.AbstractJpaQuery.execute(AbstractJpaQuery.java:143)
	at org.springframework.data.repository.core.support.RepositoryMethodInvoker.doInvoke(RepositoryMethodInvoker.java:137)
	at org.springframework.data.repository.core.support.RepositoryMethodInvoker.invoke(RepositoryMethodInvoker.java:121)
	at org.springframework.data.repository.core.support.QueryExecutorMethodInterceptor.doInvoke(QueryExecutorMethodInterceptor.java:159)
	at org.springframework.data.repository.core.support.QueryExecutorMethodInterceptor.invoke(QueryExecutorMethodInterceptor.java:138)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
	at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:123)
	at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:388)
	at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:119)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
	at org.springframework.dao.support.PersistenceExceptionTranslationInterceptor.invoke(PersistenceExceptionTranslationInterceptor.java:137)
	... 140 common frames omitted
Caused by: java.sql.SQLException: HOUR_OF_DAY: 2 -> 3
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89)
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63)
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:73)
	at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:85)
	at com.mysql.cj.jdbc.result.ResultSetImpl.getTimestamp(ResultSetImpl.java:923)
	at com.mysql.cj.jdbc.result.ResultSetImpl.getTimestamp(ResultSetImpl.java:968)
	at com.zaxxer.hikari.pool.HikariProxyResultSet.getTimestamp(HikariProxyResultSet.java)
	at org.hibernate.type.descriptor.sql.TimestampTypeDescriptor$2.doExtract(TimestampTypeDescriptor.java:84)
	at org.hibernate.type.descriptor.sql.BasicExtractor.extract(BasicExtractor.java:47)
	at org.hibernate.type.AbstractStandardBasicType.nullSafeGet(AbstractStandardBasicType.java:257)
	at org.hibernate.type.AbstractStandardBasicType.nullSafeGet(AbstractStandardBasicType.java:253)
	at org.hibernate.type.AbstractStandardBasicType.nullSafeGet(AbstractStandardBasicType.java:243)
	at org.hibernate.type.AbstractStandardBasicType.hydrate(AbstractStandardBasicType.java:329)
	at org.hibernate.persister.entity.AbstractEntityPersister.hydrate(AbstractEntityPersister.java:3214)
	at org.hibernate.loader.Loader.loadFromResultSet(Loader.java:1887)
	at org.hibernate.loader.Loader.hydrateEntityState(Loader.java:1811)
	at org.hibernate.loader.Loader.instanceNotYetLoaded(Loader.java:1784)
	at org.hibernate.loader.Loader.getRow(Loader.java:1624)
	at org.hibernate.loader.Loader.getRowFromResultSet(Loader.java:748)
	at org.hibernate.loader.Loader.getRowsFromResultSet(Loader.java:1047)
	at org.hibernate.loader.Loader.processResultSet(Loader.java:998)

[nobodyiam]

This looks like a MySQL timezone setting issue.
Adding serverTimezone=Asia/Shanghai is one of the solutions to solve this issue but I think it's better not to add it to build.sh, as this will affect those users who are not in China and users who need it could still change it in application-github.properties.

[zouyx]

+1 binding to release

I've checked

• All uts passed.
• Download links are fine.
• Shasum are correct.

[pengweiqhca]

+1 Release this package.

[Anilople]

When I deploy configservice 2.0.0-RC1 meet some error

phenomenon

Caused by: javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is disabled or cipher suites are inappropriate)
	at sun.security.ssl.HandshakeContext.<init>(HandshakeContext.java:171)
...
Caused by: org.hibernate.HibernateException: Access to DialectResolutionInfo cannot be null when 'hibernate.dialect' not set
	at org.hibernate.engine.jdbc.dialect.internal.DialectFactoryImpl.determineDialect(DialectFactoryImpl.java:100)

full log
apollo-configservice.2.0.0-RC1.log.zip

cause

see #1065

solution

change config/application-github.properties

add useSSL=false to spring.datasource.url

spring.datasource.url = jdbc:mysql://myIp:3306/mydb?characterEncoding=utf8&useSSL=false

my machine environment

os

[wxq@localhost configservice]$ lsb_release -a
LSB Version:    :core-4.1-amd64:core-4.1-noarch
Distributor ID: CentOS
Description:    CentOS Linux release 8.3.2011
Release:        8.3.2011
Codename:       n/a

java

[wxq@localhost configservice]$ java -version
openjdk version "1.8.0_275"
OpenJDK Runtime Environment (build 1.8.0_275-b01)
OpenJDK 64-Bit Server VM (build 25.275-b01, mixed mode)

MySQL version 5.7.34-log

[nobodyiam]

My local MySQL version was 5.7.25 and it works well with Oracle JDK 8, 11 and 17 without useSSL=false.
I then upgraded MySQL to 8.0.28 and it also works well...
So I did some research and it looks like it might be related to OpenJDK itself, which has some issues in the tls version negotiation.
Would you please try the enabledTLSProtocols option? e.g.

spring.datasource.url = jdbc:mysql://myIp:3306/mydb?characterEncoding=utf8&enabledTLSProtocols=TLSv1.2

If it still doesn't work, would you please try to upgrade the mysql-connector-java version to 8.0.28 and then test again?

[Anilople]

When change the config to

spring.datasource.url = jdbc:mysql://myIp:3306/mydb?characterEncoding=utf8&enabledTLSProtocols=TLSv1.2

It does work well on my machine without useSSL=false.

[Anilople]

When upgrade mysql-connector-java to 8.0.28, and use config

spring.datasource.url = jdbc:mysql://myIp:3306/mydb?characterEncoding=utf8

not use useSSL=false, it work well.

[nobodyiam]

I believe this is the feature since the 8.0.18 version. Reference

For Connector/J 8.0.18 and earlier when connecting to MySQL Community Server 5.6 and 5.7 using the JDBC API: Due to compatibility issues with MySQL Server compiled with yaSSL, Connector/J does not enable connections with TLSv1.2 and higher by default. When connecting to servers that restrict connections to use those higher TLS versions, enable them explicitly by setting the Connector/J connection property enabledTLSProtocols (e.g., set enabledTLSProtocols=TLSv1.2,TLSv1.3).

[nisiyong]

I think the changelog "What's Changed" is too long, it will be better if we separate it. Like client-side changes and server-side changes, or features and bugfix.

[nobodyiam]

Good suggestion, I just separated the What's Changed into 3 sections: Features, Bugfixes, and Misc. Please take a look.

[nobodyiam]

@lepdou @Anilople

#4308 was merged to upgrade mysql-connector-java to version 8.0.28, now users should be able to run apollo without useSSL=false or enabledTLSProtocols=TLSv1.2,TLSv1.3 no matter what the JDK is. Please help to verify again.

[Anilople]

@nobodyiam Verify done. configservice, adminservice and portal can run on my machine without useSSL=false or enabledTLSProtocols=TLSv1.2,TLSv1.3

[lepdou]

@nobodyiam It's ok when after upgrading mysql-connector-java to version 8.0.28.

My local machine's version:

• Java:1.8.0_301
• Mysql: 5.7.18

[Anilople]

+1 binding to release

I've checked

• All uts passed.
• Download links are fine.
• Shasum are correct.

[nisiyong]

After the #4308 merged, I download the new release and run it fine.

+1 binding to release, and I have Checked

• All uts passed.
• Release Note.
• Shasum are correct.
• Download links are fine.
• Deploying the new releases are fine.

[nobodyiam]

The vote to release Apollo version 2.0.0-RC1 has passed with three +1 binding, three +1, and zero -1.