Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get CocoaPods working again #1334

Closed
thomasvl opened this issue Nov 2, 2022 · 1 comment · Fixed by #1341
Closed

Get CocoaPods working again #1334

thomasvl opened this issue Nov 2, 2022 · 1 comment · Fixed by #1341

Comments

@thomasvl
Copy link
Collaborator

thomasvl commented Nov 2, 2022

Post #1331, pod lib lint SwiftProtobuf.podspec fails because the sources have changed layout.

When we add products to the Package.swift, we'll want subspecs, but for the time being what we conceptually want is probably:

diff --git a/SwiftProtobuf.podspec b/SwiftProtobuf.podspec
index bad55155..ebce3606 100644
--- a/SwiftProtobuf.podspec
+++ b/SwiftProtobuf.podspec
@@ -15,7 +15,7 @@ Pod::Spec.new do |s|
 
   s.cocoapods_version = '>= 1.7.0'
 
-  s.source_files = 'Sources/SwiftProtobuf/**/*.swift'
+  s.source_files = 'Sources/SwiftProtobufCore/*.swift', 'Sources/SwiftProtobufFoundationCompat/*.swift'
 
   s.swift_versions = ['5.0']
 end

However that will still fail because the code expects to be compiled into two modules, which isn't what CocoaPods does even if it were subspecs

fyi @gjcairo @FranzBusch

@thomasvl
Copy link
Collaborator Author

thomasvl commented Nov 9, 2022

Looking at Firebase, there may be a way to do this by publishing multiple podspecs.

thomasvl added a commit to thomasvl/swift-protobuf that referenced this issue Nov 9, 2022
Model what Firebase seems to do, have a podspec for each of the modules and
have dependencies between them.

Add a helper to the Makefile for running `pod lib lint`.

Update the docs on what publishing is likely going to take.

Fixes apple#1334
thomasvl added a commit to thomasvl/swift-protobuf that referenced this issue Nov 9, 2022
Model what Firebase seems to do, have a podspec for each of the modules and
have dependencies between them.

Add a helper to the Makefile for running `pod lib lint`.

Update LibraryVersions.py to handle the multiple podspecs.

Update the docs on what publishing is likely going to take.

Fixes apple#1334
thomasvl added a commit that referenced this issue Nov 9, 2022
Model what Firebase seems to do, have a podspec for each of the modules and
have dependencies between them.

Add a helper to the Makefile for running `pod lib lint`.

Update LibraryVersions.py to handle the multiple podspecs.

Update the docs on what publishing is likely going to take.

Fixes #1334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant