Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estuary can't be build because of undefined blockstore.ErrNotFound calls #402

Closed
fbac opened this issue Aug 16, 2022 · 1 comment
Closed
Assignees
Labels
Bug Something that should be fixed.

Comments

@fbac
Copy link

fbac commented Aug 16, 2022

estuary can't be built due to undefined blockstore.ErrNotFound functions called:

# github.com/application-research/estuary/util/migratebs
util/migratebs/blockstore.go:132:34: undefined: blockstore.ErrNotFound
util/migratebs/blockstore.go:147:34: undefined: blockstore.ErrNotFound
util/migratebs/blockstore.go:185:34: undefined: blockstore.ErrNotFound

To Reproduce
Steps to reproduce the behavior:

  1. Clone the repository
  2. Run "make clean all" to start the build

Expected behavior
estuary correctly built

Actual behavior
estuary build fails because of undefined functions being called

Additional context
blockstore changed its way to raise ErrNotFound since this PR, which breaks compatibility.
The logic should be changed to use ipld.ErrNotFound instead of blockstore.ErrNotFound.

@fbac fbac added the Bug Something that should be fixed. label Aug 16, 2022
@alvin-reyes
Copy link
Contributor

This is now fixed on the dev branch. Feel free to re-open this issue if you have concerns, alternatively you can reach out to us on our slack channel.

@alvin-reyes alvin-reyes self-assigned this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that should be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants