-
Notifications
You must be signed in to change notification settings - Fork 12
Allow The regex matching on fullpath or the on only the filename/ (leaf directory) #38
Comments
@neeraj-laad do you have an opinion? In looking at the current stacks REGEX settings, I think java-spring-boot2 might have an issue with changing it universally. Given no one is currently broken, we can take our time in making a decision on this. |
If we do this, we'd need to do the following:
APPSODY_REGEX_FULL_PATH (true/false) default is false
appsodyRegexFullPath:= os.Getenv("APPSODY_REGEX_FULL_PATH")
Note that the real work here would be testing it on the stacks. For now we stick to the default of false, but if it were decided to make the default true, it would be a lot of work to go through the 15+ stacks and test if making it full path broke anything re: the regex. |
If you want to have both full path and file only, you'd need two filter hooks, and you'd need probably multiple watchdir/regex pairs, and they would need to be ordered. So that feature would be more work. |
Currently the APPSODY_REGEX only is used against the file name or leaf directory rather than the full path.
It would be desirable to give users a choice.
Other Options:
It is also possible that we could default to the full path. But we would want to make sure we don't break existing stacks.
The text was updated successfully, but these errors were encountered: