Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Suffix #5

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Removing Suffix #5

merged 1 commit into from
Apr 3, 2024

Conversation

gambol99
Copy link
Member

@gambol99 gambol99 commented Apr 3, 2024

Removing the -rw suffix on the read write role, as it makes it easier to integrate with existing consumers and pipelines

Copy link

github-actions bot commented Apr 3, 2024

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 📁 Terraform Security Check: success
  • 📖 Terraform Documentation: success

Working Directory: modules/remote_state
Pusher: @gambol99, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-oidc/actions/runs/8536622811

Copy link

github-actions bot commented Apr 3, 2024

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 📁 Terraform Security Check: success
  • 📖 Terraform Documentation: success

Working Directory: modules/role
Pusher: @gambol99, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-oidc/actions/runs/8536622811

Copy link

github-actions bot commented Apr 3, 2024

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 📁 Terraform Security Check: success
  • 📖 Terraform Documentation: success

Working Directory: modules/provider
Pusher: @gambol99, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-oidc/actions/runs/8536622811

@gambol99 gambol99 changed the title ReadWrite Role Suffix Optional Removing Suffix Apr 3, 2024
only the read and terraform state roles will have the suffix
@gambol99 gambol99 merged commit 6b42ee0 into main Apr 3, 2024
24 checks passed
@gambol99 gambol99 deleted the feat_rw_suffix branch April 3, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant