-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Graph deleted before aptly exits #1214
Open
reglim
wants to merge
3
commits into
master
Choose a base branch
from
fix/1213-aptly-graph-removed-before-exiting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+114
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reglim
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
6 times, most recently
from
September 15, 2023 07:07
8655777
to
7192f1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
+ Coverage 74.82% 74.86% +0.03%
==========================================
Files 157 157
Lines 18176 18168 -8
==========================================
Hits 13601 13601
+ Misses 3468 3460 -8
Partials 1107 1107 ☔ View full report in Codecov by Sentry. |
randombenj
approved these changes
Sep 15, 2023
reglim
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
December 13, 2023 07:59
7192f1e
to
486e864
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
June 8, 2024 21:10
2ee09ab
to
33fe7de
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
July 31, 2024 20:32
33fe7de
to
cc3403f
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
September 26, 2024 15:14
cc3403f
to
8a44c89
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
2 times, most recently
from
October 9, 2024 18:22
bf34f8a
to
9cb754a
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
October 22, 2024 19:08
9cb754a
to
be893e5
Compare
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
November 8, 2024 18:19
be893e5
to
446ada5
Compare
iofq
approved these changes
Nov 17, 2024
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
November 17, 2024 17:40
446ada5
to
0d28427
Compare
The temporary output file is now only deleted after copying it to the output location. Fixes: #1213
neolynx
force-pushed
the
fix/1213-aptly-graph-removed-before-exiting
branch
from
December 1, 2024 10:08
0d28427
to
4be2935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1213
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
The temporary output file is now only deleted after copying it to the output location.
We no longer wait 1s for the open command, but exit immediately, since the process will continue running even after aptly exits.
Why this change is important?
Because the assumption was made that any application that opened the image would continue displaying it, even if the image was removed right after, which isn't true for the Gnome Image Viewer.
Checklist
AUTHORS