Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Graph deleted before aptly exits #1214

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

reglim
Copy link
Contributor

@reglim reglim commented Sep 13, 2023

Fixes: #1213

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

The temporary output file is now only deleted after copying it to the output location.
We no longer wait 1s for the open command, but exit immediately, since the process will continue running even after aptly exits.

Why this change is important?

Because the assumption was made that any application that opened the image would continue displaying it, even if the image was removed right after, which isn't true for the Gnome Image Viewer.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@reglim reglim force-pushed the fix/1213-aptly-graph-removed-before-exiting branch 6 times, most recently from 8655777 to 7192f1e Compare September 15, 2023 07:07
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.86%. Comparing base (b7e91f0) to head (4be2935).

Files with missing lines Patch % Lines
cmd/graph.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
+ Coverage   74.82%   74.86%   +0.03%     
==========================================
  Files         157      157              
  Lines       18176    18168       -8     
==========================================
  Hits        13601    13601              
+ Misses       3468     3460       -8     
  Partials     1107     1107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reglim reglim force-pushed the fix/1213-aptly-graph-removed-before-exiting branch from 7192f1e to 486e864 Compare December 13, 2023 07:59
@neolynx neolynx self-assigned this Jun 8, 2024
@neolynx neolynx force-pushed the fix/1213-aptly-graph-removed-before-exiting branch from 2ee09ab to 33fe7de Compare June 8, 2024 21:10
@neolynx neolynx force-pushed the fix/1213-aptly-graph-removed-before-exiting branch from 33fe7de to cc3403f Compare July 31, 2024 20:32
@neolynx neolynx force-pushed the fix/1213-aptly-graph-removed-before-exiting branch from cc3403f to 8a44c89 Compare September 26, 2024 15:14
@neolynx neolynx force-pushed the fix/1213-aptly-graph-removed-before-exiting branch 2 times, most recently from bf34f8a to 9cb754a Compare October 9, 2024 18:22
@neolynx neolynx force-pushed the fix/1213-aptly-graph-removed-before-exiting branch from 9cb754a to be893e5 Compare October 22, 2024 19:08
@neolynx neolynx force-pushed the fix/1213-aptly-graph-removed-before-exiting branch from be893e5 to 446ada5 Compare November 8, 2024 18:19
@neolynx neolynx force-pushed the fix/1213-aptly-graph-removed-before-exiting branch from 446ada5 to 0d28427 Compare November 17, 2024 17:40
@neolynx neolynx force-pushed the fix/1213-aptly-graph-removed-before-exiting branch from 0d28427 to 4be2935 Compare December 1, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aptly graph image is removed immediately after rendering
4 participants