Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Command-Line Flags Parsing for Buffers, General, and Capabilities #4449

Closed
8 tasks
ShohamBit opened this issue Dec 18, 2024 · 1 comment
Closed
8 tasks
Assignees

Comments

@ShohamBit
Copy link
Collaborator

Background
To ensure the new configuration system is comprehensive, we need command-line flag support for buffer sizes, general settings, and capabilities management. These options let users fine-tune internal buffers, specify a working directory, and adjust capabilities all from the CLI.

Tasks

Buffers Flags

  • --buffers user-events=<size>: Set the user event buffer size.
  • --buffers kernel-events=<size>: Set the kernel event buffer size.
  • --buffers kernel-blobs=<size>: Set the kernel blob buffer size.
  • --buffers kernel-control-plane=<size>: Set the kernel control plane buffer size.

General Flags

  • --general working-dir=<path>: Set the working directory for temporary files and other operations.

Capabilities Flags

  • --capabilities bypass=<true/false>: Enable or disable capability bypass (keep all capabilities).
  • --capabilities add=<capability> (repeatable): Add specific capabilities.
  • --capabilities drop=<capability> (repeatable): Drop specific capabilities.

Acceptance Criteria

  • All buffer, general, and capabilities flags parse correctly.
  • Invalid values produce helpful error messages.
  • The parsed settings integrate well with other configuration sections for a fully merged configuration.

Why This Matters
Buffer sizes directly affect performance and resource usage, while general and capabilities settings affect system behavior and security. By enabling these to be set or overridden via CLI flags, we give users finer control and the flexibility to adjust configurations on the fly without editing config files.

@yanivagman
Copy link
Collaborator

Part of #4453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants