From 3f3575594c03da6035a680d61d976ec7a181b384 Mon Sep 17 00:00:00 2001 From: Anthony Mahanna Date: Fri, 19 Jan 2024 10:21:31 -0500 Subject: [PATCH] fix benchmark assertions --- benchmark/compare.py | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/benchmark/compare.py b/benchmark/compare.py index 1b7e5a5..6a59e61 100644 --- a/benchmark/compare.py +++ b/benchmark/compare.py @@ -9,8 +9,15 @@ def sort_children_by_start_time(children): def compare_span(master_child: Optional[dict], branch_child: Optional[dict]): if master_child and branch_child: - assert master_child.get("operationName") == branch_child.get("operationName") - assert master_child.get("tags") == branch_child.get("tags") + assert master_child.get("operationName") == branch_child.get("operationName"), ( + f"Master Child Operation Name: {master_child.get('operationName')}\n" + f"Branch Child Operation Name: {branch_child.get('operationName')}" + ) + + assert master_child.get("tags") == branch_child.get("tags"), ( + f"Master Child Tags: {master_child.get('tags')}\n" + f"Branch Child Tags: {branch_child.get('tags')}" + ) operation_name = ( master_child.get("operationName") @@ -102,8 +109,15 @@ def compare_children(master_children: list[dict], branch_children: list[dict]): def compare_traces(master_trace: dict, branch_trace: dict): - assert master_trace.get("operationName") == branch_trace.get("operationName") - assert master_trace.get("tags") == branch_trace.get("tags") + assert master_trace.get("operationName") == branch_trace.get("operationName"), ( + f"Master Operation Name: {master_trace.get('operationName')}\n" + f"Branch Operation Name: {branch_trace.get('operationName')}" + ) + + assert master_trace.get("tags") == branch_trace.get("tags"), ( + f"Master Tags: {master_trace.get('tags')}\n" + f"Branch Tags: {branch_trace.get('tags')}" + ) result = { "operationName": master_trace["operationName"],